Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.x] Supports Laravel 12 #708

Merged
merged 5 commits into from
Feb 19, 2025

Conversation

crynobone
Copy link
Contributor

No description provided.

Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
Signed-off-by: Mior Muhammad Zaki <[email protected]>
@crynobone
Copy link
Contributor Author

https://packagist.org/packages/inertiajs/inertia-laravel/php-stats#1

Notes: PHP 7.3 has 0% downloads for a couple of months while PHP 7.4 downloads only max around 0.4%

Signed-off-by: Mior Muhammad Zaki <[email protected]>
exclude:
- php: 7.3
laravel: 8 # Failed security advisory
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failed security advisory due to unable to match any fixes GHSA-c2pc-g5qf-rfrf on PHP 7.3

@RobertBoes
Copy link
Contributor

Does Inertia 1.x still need maintenance? The v1 docs are pretty much hidden, it's only linked on the upgrade guide (which is kinda the last place to look at when you're looking for older docs), so I'd assume v1 only receives bug fixes and not updates?

@pascalbaljet
Copy link

Does Inertia 1.x still need maintenance? The v1 docs are pretty much hidden, it's only linked on the upgrade guide (which is kinda the last place to look at when you're looking for older docs), so I'd assume v1 only receives bug fixes and not updates?

I recently asked on X, and many people are still on v1. If it's just a version bump in the composer file, it's not such a big deal, right?

@RobertBoes
Copy link
Contributor

I recently asked on X, and many people are still on v1. If it's just a version bump in the composer file, it's not such a big deal, right?

A version bump doesn't seem like much on the surface, but that would imply 1.x is actively maintained. If that's the case then I'd also expect fixes to be back-ported to 1.x, which as far as I know isn't the case right now.

I also get that people still use 1.x, so they're not using the current active version. So why should they be pushed to upgrade to Laravel 12, but not to Inertia 2.x? Maintaining multiple versions, for whatever reason, adds to the maintenance. I don't see the point of supporting Laravel 12, as Laravel 11 is still supported to until February 3, 2026. So that's plenty of time to upgrade?

@crynobone
Copy link
Contributor Author

You can use inertiajs/inertia-laravel v1 with Inertia.js 2 (npm). This is possible for Laravel packages to get updated to Inertia.js v2 while the application is stucked with v1.

This has no relation to Inertia.js v1 support policy.

@pascalbaljet
Copy link

So why should they be pushed to upgrade to Laravel 12, but not to Inertia 2.x?

The goal of Laravel 12 is to be an upgrade with no breaking changes. As much as I love all the work put into Inertia v2, there are still some bugs that prevent people from going into production with it. So, I can imagine people wanting to jump on L12 to get the benefits of new features, but at the same time, they are hesitant to upgrade to Inertia v2.

@joetannenbaum joetannenbaum merged commit 206b1ba into inertiajs:1.x Feb 19, 2025
28 checks passed
@crynobone crynobone deleted the inertia-1-laravel-12 branch February 19, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants