This repository has been archived by the owner on May 25, 2023. It is now read-only.
Add RFC references for IP.Is<Property>() methods #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These helped me to cross reference inet.af/netaddr, net.IP, and github.com/mellowdrifter/bogons for inetaf#151. Signed-off-by: Alex Willmer <[email protected]>
|
If you prefer to reject these summarily then please do. I won't be offended, and I won't contest it. |
danderson
approved these changes
May 23, 2021
|
@moreati any chance I could bother you to sign a Google CLA for this and your WIP examples PR? We are hoping to upstream netaddr into the Go standard library, and this is one of the requirements. See the Go contribution guidelines for the details: https://golang.org/doc/contribute#cla |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These helped me to cross reference inet.af/netaddr, net.IP, and
github.com/mellowdrifter/bogons for #151.
Signed-off-by: Alex Willmer [email protected]