-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Online Boolean to Events #105
Comments
My suggestion for when services don't offer a boolean is to see what they use for the common |
For clarifications, and using Meetup as an example, the
This is a simple example for Meetup, but the above logic will have to be implemented for both Eventbrite and Google Calendar. |
#116 is the proposed fix |
following a recent discussion here's another idea: what if it was an integer value with these possible values:
|
the option of 0 will be useful for older calendar events/groups that were set as recurring events years ago. where those events were still apparently offline during strict covid19 lockdown times it could be assumed that those events should be 0. having just three possible values will help ensure efficient, effective, easy to validate data structure. |
the easiest way to implement this would probably be to add events to a list, which can then be read, each of the events listed could be set to 0 |
This was a great idea at the time, although thinking about it now, hybrid events are a thing, so maybe having two booleans would be better ( |
To clarify, either two of the Booleans being |
For the TechNW Google Calendar, we can take a recurring event (based on the name being the same) and sample three instances of the event, one prior to COVID-19, one during peak lock-down (where in-person events could not legally happen) and one after, with those three events if the location remains the same, we can set the event to false for both |
is this still in the scope of this issue? Otherwise I have done everything else |
Good question @prototype99, we could leave this issue here, where checking if the location of an event includes the string |
Since the pandemic some services like Meetup have added
is_online_event
boolean's to their event API endpoint, this should be generalised across all platforms and be unified into anonline
boolean in the following definition, which will be used in #100.compiled-mcr-events/_data/sources/templates/event.js
Lines 1 to 18 in d934949
The text was updated successfully, but these errors were encountered: