Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online status pr #116

Merged
merged 13 commits into from
Oct 19, 2021
Merged

Conversation

prototype99
Copy link
Contributor

this adds online status checks, this pull request depends on #108

@netlify
Copy link

netlify bot commented Oct 12, 2021

✔️ Deploy Preview for manchester-tech-events ready!

🔨 Explore the source changes: 99958db

🔍 Inspect the deploy log: https://app.netlify.com/sites/manchester-tech-events/deploys/616da5908c83a10007e3c07e

😎 Browse the preview: https://deploy-preview-116--manchester-tech-events.netlify.app

@prototype99 prototype99 force-pushed the online-status-pr branch 2 times, most recently from 92eaeb7 to ac6fc1d Compare October 15, 2021 12:49
Copy link
Member

@Sean12697 Sean12697 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the immediate changes I saw whiles reviewing #108, looking at the TaTC: Myths, Legends and Unicorns event on Meetup, it is certainly in person (we know the organiser), but the current data based on my #108 suggestions is the following (where is_online_event and is_offline_event are false). Tbf, I might have checked out the wrong commit / branch or something for that specific issue.

{
    name: 'TaTC: Myths, Legends and Unicorns  ',
    link: 'https://meetu.ps/3mGlrL',
    location: 'No.1 Spinningfields - 1 Hardman Street (M3 3EB)',
    desc: 'Hello you beautiful pandas!!!!\n' +
      '\n' +
      "We are back!!! This is our first in person event since the dreaded L, and we cannot WAIT to see all of your lovely smiling faces. We've deliberately picked talks that are high impact, only 20 mins long, with plenty of time for breaks and socialising and networking!!\n" +
      '\n' +
      'Super grateful to our joint sponsors, Moneysupermarket.com and Venturi!\n' +
      '\n' +
      "We'll be enjoying an inclusive range of food and drinks at the wonderful MSM offices and courtesy of them, and then the very kind folks at tech recruitment powerhouse Venturi are treating us all to a drink afterwards! (if you prefer a milkshake to an alcoholic beverage, that is completely cool with us. Just ask John G, the absolute Oreo fiend)\n" +
      '\n' +
      'Agenda\n' +
      '\n' +
      '17:30pm - doors open and registration\n' +
      '18:10pm - event starts, introduction and code of conduct\n' +
      '\n' +
      '18:20pm - First speaker! [20 Minutes]\n' +
      'Mhairi Davidson - Senior Agile Delivery Lead at Nimble Approach\n' +
      '"How to keep a collaborative culture thriving post pandemic"\n' +
      '\n' +
      '18:40pm - Lightning Talk [10 Minutes]\n' +
      'Amy Newton - Founder at Inclusively Tech\n' +
      'MythBusting - "Blind/anonymous CVs help reduce unconscious bias - why this is a myth and what you should do instead"\n' +
      '\n' +
      '18:50pm - Comfort Break\n' +
      '\n' +
      '19:00pm - Second speaker!\n' +
      'Kristian Epps - Front End Lead at Matillion\n' +
      '"Building a UI fit for a Unicorn"\n' +
      '\n' +
      '19:20pm - comfort break\n' +
      '\n' +
      '19:30pm - Third speaker!\n' +
      'Mikey Smith - Technology Director at MoneySupermarket\n' +
      '"Breaking down silos and focusing on the customer"\n' +
      '\n' +
      '19:50pm - Wrap up and mingle mingle\n' +
      '20:15pm - vacate and go to pub (TBD) HUGE thank you to Venturi for sponsoring our pub-going <3 <3\n' +
      '\n' +
      'If anyone has any anxiety about being in a large crowd again please do get in touch with me directly if you would like me to buddy you up with someone as you are walking in [email protected]\n' +
      '\n' +
      'If anyone has any additional needs please let us know.\n' +
      '\n' +
      'Disabled access: The building has disabled access and lifts, they are on the 16th floor so they are needed!\n' +
      '\n' +
      'To ensure the safety and well-being of both our hosts and our community we require that you provide proof of both vaccines OR a negative test from the past 48 hours in order to attend this event.',
    startTimeISO: '2021-10-19T17:30+01:00',
    endTimeISO: '2021-10-19T19:30+01:00',
    going: 69,
    capacity: 75,
    free: false,
    cost: null,
    groupName: 'Techs and the City',
    groupLink: 'https://www.meetup.com/Techs-and-The-City',
    source: 'Meetup',
    ad: false,
    is_online_event: false,
    is_offline_event: false
  }

@prototype99
Copy link
Contributor Author

I am confused, aren't the variables already within the constructor?

@Sean12697
Copy link
Member

@prototype99

@prototype99
Copy link
Contributor Author

yeah I rebased it onto the latest master branch now

@prototype99
Copy link
Contributor Author

ohhh I see what you're saying, one moment

@prototype99
Copy link
Contributor Author

there we go done

@Sean12697 Sean12697 merged commit 7d32242 into inevitable-team:master Oct 19, 2021
@Sean12697 Sean12697 added the hacktoberfest-accepted Accept for Hacktoberfest, will merge later label Oct 19, 2021
@Sean12697 Sean12697 linked an issue Oct 19, 2021 that may be closed by this pull request
@prototype99 prototype99 deleted the online-status-pr branch October 19, 2021 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accept for Hacktoberfest, will merge later
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Online Boolean to Events
2 participants