Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for breaking unit tests on newly created projects #761

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Fix for breaking unit tests on newly created projects #761

merged 3 commits into from
Sep 20, 2023

Conversation

ElonVolo
Copy link
Contributor

@ElonVolo ElonVolo commented Jun 6, 2022

Fix for #760.

montera82
montera82 approved these changes Aug 4, 2022
View reviewed changes
Copy link

@montera82 montera82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

worked for me when i bumped ts-node version as done in this PR.

@jamonholmgren
Copy link
Member

I'm not sure what the CI failure is here. Don't currently have time to dig into it. Are tests passing locally?

@rodrigo-picanco
Copy link

Worked for me as well

@ElonVolo
Copy link
Contributor Author

It's not just tests breaking, though. Now, when you create a stock typescript and run it it breaks.

@ElonVolo
Bumping ts-node version
51183fa 
asdf
Bumping sadf
@ElonVolo ElonVolo force-pushed the fix/ts-node-unit-tests branch from 0af1a55 to 51183fa Compare August 19, 2022 19:43
@ElonVolo
Copy link
Contributor Author

@jamonholmgren Some act of weird gitness stripped the command from the end of a line in package.json. Assuming this passes tests it should be a fix

@jamonholmgren jamonholmgren mentioned this pull request Sep 20, 2023
Closed
@jamonholmgren jamonholmgren merged commit b93f6bd into infinitered:master Sep 20, 2023
infinitered-circleci pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
chore(release): 5.1.4 [skip ci]
9e7a790 
## [5.1.4](v5.1.3...v5.1.4) (2023-09-20)

### Bug Fixes

* **deps:** Updates ts-node to 10.9.1 ([#761](#761) by @ElonVolo and [@marcelxsilva](https://github.com/marcelxsilva)) ([b93f6bd](b93f6bd))
@infinitered-circleci
Copy link

🎉 This PR is included in version 5.1.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@montera82 montera82 montera82 approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ElonVolo @jamonholmgren @rodrigo-picanco @infinitered-circleci @montera82