Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): add --legacy-peer-deps for npm users #2823

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix(cli): add --legacy-peer-deps for npm users #2823

merged 2 commits into from
Oct 29, 2024

Conversation

frankcalise
Copy link
Contributor

Please verify the following:

  • yarn test jest tests pass with new tests, if relevant
  • yarn lint eslint checks pass with new code, if relevant
  • yarn format:check prettier checks pass with new code, if relevant
  • README.md (or relevant documentation) has been updated with your changes
  • If this affects functionality there aren't tests for, I manually tested it, including by generating a new app locally if needed (see docs).

Describe your PR

  • Closes eslint-plugin-n, eslint-config-standard conflicting in Ignite X #2818
  • Utilizes the error's suggested flag, --legacy-peer-deps to resolve some mislabeled peer dep upstream regarding some eslint packages (see issue for further details linking to eslint-plugin-n and -standard - seems as if there might be a newer plugin neostandard to consider?)

@frankcalise frankcalise merged commit e59d880 into master Oct 29, 2024
1 check passed
@frankcalise frankcalise deleted the fix/2818 branch October 29, 2024 21:54
infinitered-circleci pushed a commit that referenced this pull request Oct 29, 2024
## [10.0.2](v10.0.1...v10.0.2) (2024-10-29)

### Bug Fixes

* **boilerplate:** expo-router keyboard provider + theme fix ([#2825](#2825) by [@frankcalise](https://github.com/frankcalise)) ([f82f324](f82f324))
* **cli:** add --legacy-peer-deps for npm users ([#2823](#2823) by [@frankcalise](https://github.com/frankcalise)) ([e59d880](e59d880))
* **cli:** fix issue with workflow prompt values ([#2821](#2821) by [@frankcalise](https://github.com/frankcalise)) ([f2cdd00](f2cdd00))
* **cli:** replace shell commands with filesystem API ([#2817](#2817) by @AsterisMono) ([fd0a418](fd0a418))
@infinitered-circleci
Copy link

🎉 This PR is included in version 10.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eslint-plugin-n, eslint-config-standard conflicting in Ignite X
2 participants