Adding CreateClientFunction #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoBurgos
reviewed
May 18, 2024
| """ | ||
| self.clients_db = DynamoDBHandler( | ||
| table_name=settings.CLIENTS_TABLE_NAME, | ||
| partition_key="Id", |
There was a problem hiding this comment.
Is partition key maped from phone to Id?
| message=str(error), | ||
| ) | ||
|
|
||
| def scan_table(self) -> Dict[str, Any]: |
There was a problem hiding this comment.
I dont thnk we are going to need this one
| data = { | ||
| "phone_number": self.client_data["phone_number"], | ||
| "name": self.client_data["name"], | ||
| "address": self.client_data["address"], |
There was a problem hiding this comment.
Suggested change
| "address": self.client_data["address"], | |
| "first_address": self.client_data["first_address"], |
| "phone_number": self.client_data["phone_number"], | ||
| "name": self.client_data["name"], | ||
| "address": self.client_data["address"], | ||
| "latitude": latitude, |
There was a problem hiding this comment.
Suggested change
| "latitude": latitude, | |
| "first_latitude": latitude, |
| "name": self.client_data["name"], | ||
| "address": self.client_data["address"], | ||
| "latitude": latitude, | ||
| "longitude": longitude, |
There was a problem hiding this comment.
Suggested change
| "longitude": longitude, | |
| "first_longitude": longitude, |
| ReadCapacityUnits: 5 | ||
| WriteCapacityUnits: 5 | ||
|
|
||
| HiBerrySearchLocationIndex: |
There was a problem hiding this comment.
why are we creating a new index? we could just refference that one
| @@ -152,6 +152,7 @@ def build_order( | |||
| "driver": driver, | |||
| "source": source.value, | |||
| "cooler": self.order_data.get("cooler", None), | |||
| "discount": self.order_data.get("discount"), | |||
There was a problem hiding this comment.
do you know why this changes appear again?
| @@ -45,6 +45,7 @@ class HIBerryOrder(DeliveryDateMixin): | |||
| delivery_address: StrictStr | |||
| phone_number: StrictStr | |||
| cart_items: List[HIBerryProduct] | |||
| discount: StrictStr | None = None | |||
There was a problem hiding this comment.
do you know why this changes appear again?
| @@ -57,6 +58,10 @@ def calculate_total_amount(cls, value, values): | |||
| calculated_total = sum( | |||
| item.price * item.quantity for item in values.get("cart_items", []) | |||
| ) | |||
| if values["discount"] and values["discount"] == "5": | |||
There was a problem hiding this comment.
do you know why this changes appear again?
| @@ -180,6 +180,10 @@ def assign_driver_for_delivery( | |||
| if driver_assigned == 0: | |||
| return 0 | |||
|
|
|||
| # Saturday is day 5, in sat only one schedule is running, so all sector are available | |||
| if day_of_week == 5: | |||
There was a problem hiding this comment.
do you know why this changes appear again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/clients