fix: add mutex

influxdata · Oct 17, 2024 · 6f4aa66 · 6f4aa66
1 parent c9331f0
commit 6f4aa66
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/tsdb/store.go b/tsdb/store.go
@@ -678,6 +678,9 @@ func (s *Store) Shard(id uint64) *Shard {
 // longer in a "bad" state. This method will return any shards that
 // were removed from the cache.
 func (s *Store) ClearBadShardList() map[uint64]error {
+	s.mu.Lock()
+	defer s.mu.Unlock()
+
 	badShards := s.GetBadShardList()
 	clear(s.badShards.shardErrors)
 

diff --git a/tsdb/store_test.go b/tsdb/store_test.go
@@ -282,7 +282,7 @@ func TestStore_BadShardClear(t *testing.T) {
 			require.ErrorIs(t, err2, tsdb.ErrPreviousShardFail{})
 			require.EqualError(t, err2, fmt.Errorf("not attempting to open shard %d; opening shard previously failed with: %w", shId, expErr).Error())
 
-			require.Equal(t, 1, len(s.Store.GetBadShardList()))
+			require.Len(t, s.Store.GetBadShardList(), 1)
 
 			badShards := s.ClearBadShardList()
 			require.Len(t, badShards, 1)