Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inputs.infiniband_hw): add support for RDMA counters #16336

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

izekr
Copy link

@izekr izekr commented Dec 19, 2024

Summary

This PR introduces a RDMA counters (in a Linux environment) to the exiting InfiniBand input plugin. The new RDMA counters gathers statistics from the hardware counters located under (for example):
/sys/class/infiniband/mlx5_0/ports/1/hw_counters/

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16334
superseeds #16335

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Dec 19, 2024
@telegraf-tiger
Copy link
Contributor

@srebhan
Copy link
Member

srebhan commented Dec 20, 2024

@izekr why opening a new PR? Anyway, the comment here on why this cannot be done in the infiniband plugin remains...

@srebhan srebhan self-assigned this Dec 20, 2024
@izekr
Copy link
Author

izekr commented Dec 20, 2024

@izekr why opening a new PR? Anyway, the comment here on why this cannot be done in the infiniband plugin remains...

@srebhan,
Following your recommendations regarding infinibnad input plugin, I will update this PR to include InfiniBand hardware statistics (RDMA diagnostics) in the infinibnad input plugin.

Note
As for #16335,
I thought that I had some issues with #16335, and that's the reason why I closed it and opened #16336.

@srebhan
Copy link
Member

srebhan commented Dec 20, 2024

Thanks for looking into merging the feature into the existing plugin!

@srebhan
Copy link
Member

srebhan commented Jan 15, 2025

@izekr any news on this PR?

@srebhan srebhan added the waiting for response waiting for response from contributor label Jan 15, 2025
@izekr
Copy link
Author

izekr commented Jan 16, 2025

@izekr any news on this PR?

@srebhan
Will return to work on it in the upcoming week

@telegraf-tiger telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jan 16, 2025
@izekr izekr closed this Jan 23, 2025
@izekr izekr reopened this Jan 23, 2025
@izekr izekr force-pushed the master branch 2 times, most recently from 97e31b8 to 652fd89 Compare January 23, 2025 18:21
@izekr izekr changed the title feat(inputs.infiniband_hw): add a new input plugin for Infiniband card/ports HW statistics feat(inputs.infiniband_hw): add support for RDMA counters Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New input plugin: InfiniBand Hardware Counters (RDAM diagnostics)
3 participants