Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch card headers from <sectiondiv> to <div> #163

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Switch card headers from <sectiondiv> to <div> #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Customization/xsl/card.xsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,18 @@
<xsl:call-template name="commonattributes"/>
<xsl:call-template name="setid"/>
<xsl:apply-templates
select="*[contains(@class, ' topic/sectiondiv ') and contains(@outputclass, 'card-header')]"
select="*[contains(@outputclass, 'card-header') and (contains(@class, ' topic/sectiondiv ') or contains(@class, ' topic/div '))]"
/>
<xsl:apply-templates select="*[contains(@outputclass, 'card-img-top')]"/>
<div class="card-body">
<xsl:apply-templates select="*[contains(@class, ' topic/title ')]" mode="card"/>
<xsl:apply-templates
select="*[not(contains(@class, ' topic/title ')) and not(contains(@outputclass, 'card-img-top')) and not(contains(@outputclass, 'card-img-bottom')) and not(contains(@outputclass, 'card-header')) and not(contains(@outputclass, 'card-footer')) ]"
select="*[not(contains(@class, ' topic/title ')) and not(contains(@outputclass, 'card-img-top')) and not(contains(@outputclass, 'card-img-bottom')) and not(contains(@outputclass, 'card-header')) and not(contains(@outputclass, 'card-footer'))]"
/>
</div>
<xsl:apply-templates select="*[contains(@outputclass, 'card-img-bottom')]"/>
<xsl:apply-templates
select="*[contains(@class, ' topic/sectiondiv ') and contains(@outputclass, 'card-footer')]"
select="*[contains(@outputclass, 'card-footer') and (contains(@class, ' topic/sectiondiv ') or contains(@class, ' topic/div '))]"
/>
</div>
</xsl:template>
Expand Down
10 changes: 5 additions & 5 deletions sample/card.dita
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,14 +71,14 @@
<title>Titles, text, and links</title>
<p>Links are added and placed next to each other by altering the <xmlatt>outputclass</xmlatt> and adding
<codeph>card-link</codeph> to an <xmlelement>xref</xmlelement> tag.</p>
<p>Subtitles are used by adding a <xmlelement>sectiondiv</xmlelement> element.</p>
<p>Subtitles are used by adding a <xmlelement>div</xmlelement> element.</p>
</section>
<bodydiv outputclass="bd-example" deliveryTarget="html">
<bodydiv outputclass="row">
<bodydiv outputclass="col">
<section outputclass="card w-50">
<title outputclass="h5">Card Title</title>
<sectiondiv outputclass="h6">Card Subtitle</sectiondiv>
<div outputclass="h6">Card Subtitle</div>
<p>Some quick example text to build on the card title and make up the bulk of the card’s content.</p>
<xref outputclass="card-link" href="#">Card Link</xref>
<xref outputclass="card-link" href="#">Another Link</xref>
Expand All @@ -90,7 +90,7 @@
&lt;bodydiv outputclass="col"&gt;
&lt;section outputclass="card w-50"&gt;
&lt;title outputclass="h5"&gt;Card Title&lt;/title&gt;
&lt;sectiondiv outputclass="h6"&gt;Card Subtitle&lt;/title&gt;
&lt;div outputclass="h6"&gt;Card Subtitle&lt;/title&gt;
&lt;p&gt;Some quick example text to build on the card title and make up the bulk of the card’s content.&lt;/p&gt;
&lt;xref outputclass="card-link" href="#"&gt;Card Link&lt;/xref&gt;
&lt;xref outputclass="card-link" href="#"&gt;Another Link&lt;/xref&gt;
Expand Down Expand Up @@ -131,7 +131,7 @@
<bodydiv outputclass="col">
<section outputclass="card w-50">
<title outputclass="h5">Special title treatment</title>
<sectiondiv outputclass="card-header">Featured</sectiondiv>
<div outputclass="card-header">Featured</div>
<p>With supporting text below as a natural lead-in to additional content.</p>
<xref href="#" outputclass="btn-primary">Go somewhere</xref>
</section>
Expand All @@ -141,7 +141,7 @@
<codeblock>&lt;bodydiv outputclass="row"&gt;
&lt;bodydiv outputclass="col"&gt;
&lt;section outputclass="card w-50"&gt;
&lt;sectiondiv outputclass="card-header"&gt;Featured&lt;/sectiondiv&gt;
&lt;div outputclass="card-header"&gt;Featured&lt;/div&gt;
&lt;title outputclass="h5"&gt;Special title treatment&lt;/title&gt;
&lt;p&gt;With supporting text below as a natural lead-in to additional content.&lt;/p&gt;
&lt;xref href="#" outputclass="btn-primary"&gt;Go somewhere&lt;/xref&gt;
Expand Down