Merge pull request #17 from infracloudio/fix/slo

restructure SLO configs
infracloudio · May 2, 2024 · 11c2ffd · 11c2ffd
2 parents 2d643d8 + c7dffbf
commit 11c2ffd
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/codebundles/rds-mysql-conn-count/runwhen-config/sli.yaml b/codebundles/rds-mysql-conn-count/runwhen-config/sli.yaml
@@ -17,7 +17,7 @@ configProvided:
       http://aeccfb7ff9bfb4705b6218294a7346c3-2081802229.us-west-2.elb.amazonaws.com/prometheus/api/v1
   - name: QUERY
     value: >-
-      aws_rds_database_connections_average{dimension_DBInstanceIdentifier="robotshopmysql"} > 1
+      aws_rds_database_connections_average{dimension_DBInstanceIdentifier="robotshopmysql"} > 30
   - name: TRANSFORM
     value: RAW
   - name: STEP

diff --git a/codebundles/rds-mysql-conn-count/runwhen-config/slo.yaml b/codebundles/rds-mysql-conn-count/runwhen-config/slo.yaml
@@ -1,8 +1,8 @@
 codeBundle:
   repoUrl: https://github.com/infracloudio/ifc-rw-codecollection
-  pathToYaml: codebundles/slo-default/queries.yaml
+  pathToYaml: codebundles/rds-mysql-conn-count/slo-queries.yaml
   ref: main
 sloSpecType: simple-mwmb
 objective: 95
-threshold: 48
+threshold: 30
 operand: lt
diff --git a/codebundles/slo-default/queries.yaml → ...les/rds-mysql-conn-count/slo-queries.yaml b/codebundles/slo-default/queries.yaml → ...les/rds-mysql-conn-count/slo-queries.yaml
@@ -1,3 +1,3 @@
 # Please update the RDS_MYSQL_DB_NAME to match your RDS instance name, for which we aim to establish the SLO based on aws_rds_database_connections_average metric
-errorQuery: "aws_rds_database_connections_average{dimension_DBInstanceIdentifier="<RDS_MYSQL_DB_NAME>"} > 30"
-totalQuery: "aws_rds_database_connections_average{dimension_DBInstanceIdentifier="<RDS_MYSQL_DB_NAME>"}"
+errorQuery: "aws_rds_database_connections_average{dimension_DBInstanceIdentifier="robotshopmysql"} > 30"
+totalQuery: "aws_rds_database_connections_average{dimension_DBInstanceIdentifier="robotshopmysql"}"