Skip to content

Commit

Permalink
Merge pull request #2265 from ing-bank/fix/revert-node-16
Browse files Browse the repository at this point in the history
Revert "Update various github actions and node versions (#2251)"
  • Loading branch information
okadurin authored Apr 18, 2024
2 parents 3cef916 + b7b0660 commit 9af813d
Show file tree
Hide file tree
Showing 3 changed files with 24 additions and 24 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,19 @@ jobs:
steps:
- uses: google/wireit@setup-github-actions-caching/v1
- name: Checkout Repo
uses: actions/checkout@v4
uses: actions/checkout@v3
with:
# This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
fetch-depth: 0

- name: Setup Node.js 18.x
uses: actions/setup-node@v4
- name: Setup Node.js 16.x
uses: actions/setup-node@v3
with:
node-version: 18.x
node-version: 16.x
registry-url: 'https://registry.npmjs.org'

- name: Install Dependencies
run: npm ci
run: npm install --ci

- name: Create Release Pull Request or Publish to npm
id: changesets
Expand Down
36 changes: 18 additions & 18 deletions .github/workflows/verify.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,18 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4
- uses: actions/checkout@v2

- name: Sanity check
run: node ./scripts/lock-scan.js

- name: Setup Node 18.x
uses: actions/setup-node@v4
- name: Setup Node 16.x
uses: actions/setup-node@v1
with:
node-version: 18.x
node-version: 16.x

- name: Install Dependencies
run: npm ci
run: npm install --ci

- name: Lint
run: npm run lint
Expand All @@ -32,15 +32,15 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4
- uses: actions/checkout@v2

- name: Setup Node 18.x
uses: actions/setup-node@v4
- name: Setup Node 16.x
uses: actions/setup-node@v1
with:
node-version: 18.x
node-version: 16.x

- name: Install Dependencies
run: npm ci
run: npm install --ci

- uses: microsoft/playwright-github-action@v1

Expand All @@ -52,19 +52,19 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [18.x]
node-version: [16.x]
os: [ubuntu-latest]
steps:
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4
- uses: actions/checkout@v2

- name: Setup Node ${{ matrix.node-version }}
uses: actions/setup-node@v4
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- name: Install Dependencies
run: npm ci
run: npm install --ci

- name: Test
run: npm run test:node
Expand All @@ -75,19 +75,19 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
node-version: [18.x]
node-version: [16.x]
os: [windows-latest]
steps:
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4
- uses: actions/checkout@v2

- name: Setup Node ${{ matrix.node-version }}
uses: actions/setup-node@v4
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- name: Install Dependencies
run: npm ci
run: npm install --ci

- name: Test
run: npm run test:node
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
16

0 comments on commit 9af813d

Please sign in to comment.