fix: add _$isValidator$ property to improve the check

ing-bank · Nov 6, 2024 · c90a6ef · c90a6ef
1 parent 51dc412
commit c90a6ef
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/ui/components/form-core/src/validate/ValidateMixin.js b/packages/ui/components/form-core/src/validate/ValidateMixin.js
@@ -687,7 +687,7 @@ export const ValidateMixinImplementation = superclass =>
       }
 
       for (const validatorToSetup of this._allValidators) {
-        if (validatorToSetup.type === undefined) {
+        if (/** @type {typeof Validator}  */ validatorToSetup._$isValidator$ === undefined) {
           // throws in constructor are not visible to end user so we do both
           const errorType = Array.isArray(validatorToSetup) ? 'array' : typeof validatorToSetup;
           const errorMessage = `Validators array only accepts class instances of Validator. Type "${errorType}" found. This may be caused by having multiple installations of "@lion/ui/form-core.js".`;

diff --git a/packages/ui/components/form-core/src/validate/Validator.js b/packages/ui/components/form-core/src/validate/Validator.js
@@ -32,6 +32,7 @@ export class Validator extends EventTarget {
      * @type {ValidationType}
      */
     this.type = config?.type || 'error';
+    this._$isValidator$ = true;
   }
 
   /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -32,6 +32,7 @@ export class Validator extends EventTarget { @@
          * @type {ValidationType}
          */
         this.type = config?.type || 'error';
+        this._$isValidator$ = true;
       }
       /**
@@ Expand Down @@