Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint proper #2254

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Update eslint proper #2254

merged 3 commits into from
Apr 23, 2024

Conversation

koddsson
Copy link
Contributor

@koddsson koddsson commented Apr 15, 2024 •
edited
Loading

What I did

  1. Updated ESLint
  2. Fixed Ignore any violations that come up

This is waiting for #2253 to land before I'll take it out of draft mode.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a84658a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@koddsson koddsson force-pushed the update-eslint-proper branch 2 times, most recently from a92db75 to 83f7c20 Compare April 16, 2024 16:25
@koddsson koddsson force-pushed the update-eslint-proper branch from 83f7c20 to a84658a Compare April 22, 2024 19:45
@koddsson koddsson marked this pull request as ready for review April 22, 2024 19:53
@gerjanvangeest gerjanvangeest merged commit c8093bd into ing-bank:master Apr 23, 2024
5 checks passed
@koddsson koddsson deleted the update-eslint-proper branch April 23, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerjanvangeest gerjanvangeest gerjanvangeest approved these changes

@tlouisse tlouisse Awaiting requested review from tlouisse tlouisse is a code owner

@narzac narzac Awaiting requested review from narzac narzac is a code owner

@Knorgias Knorgias Awaiting requested review from Knorgias Knorgias is a code owner

@okadurin okadurin Awaiting requested review from okadurin okadurin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@koddsson @gerjanvangeest