Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix select rich key interaction not setting correct isTriggeredByUser value #2262

Merged

Conversation

SomaH123
Copy link
Contributor

What I did

  1. I fixed [ArrowUp]/[ArrowDown] not setting isTriggeredByUser to true when done directly on the select-rich component, not in the listbox

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 8c4d215

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@SomaH123 SomaH123 changed the title Fix/select rich triggered by user Fix select rich key interaction not setting correct isTriggeredByUser value Apr 18, 2024
@gerjanvangeest gerjanvangeest force-pushed the fix/select-rich-triggered-by-user branch from 9feca8a to 8c4d215 Compare April 23, 2024 07:54
Copy link
Member

@gerjanvangeest gerjanvangeest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SomaH123 looks good 💪

@gerjanvangeest gerjanvangeest merged commit 3a1482f into ing-bank:master Apr 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants