Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up cache properly if session ID changes #2267

Conversation

ing-athirlwall
Copy link
Contributor

@ing-athirlwall ing-athirlwall commented Apr 18, 2024

What I did

  1. Sometimes the logged in session ID will change when processing a "pending" request before a "current" request is processed, meaning that the "current" request no longer should be cached. This PR cleans up and invalidates the request and cache if the session ID changes.

Copy link

changeset-bot bot commented Apr 18, 2024

🦋 Changeset detected

Latest commit: 23d5cf7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@lion/ajax Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@ing-athirlwall ing-athirlwall marked this pull request as draft April 30, 2024 12:38
@ing-athirlwall ing-athirlwall force-pushed the feat/clean-up-cache-properly-when-cache-changes branch 2 times, most recently from e96bafb to b4c2824 Compare May 3, 2024 11:56
@ing-athirlwall ing-athirlwall force-pushed the feat/clean-up-cache-properly-when-cache-changes branch from b4c2824 to 23d5cf7 Compare May 7, 2024 07:31
@tlouisse tlouisse marked this pull request as ready for review May 7, 2024 08:23
@tlouisse tlouisse merged commit df8bf58 into ing-bank:master May 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants