feat:글 조회 수정 삭제 삽입 #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test구현 예정입니다. 예외처리 한 번 봐주시면 감사하겠습니다 [#8]
sleeg00
requested review from
Dark-jin,
DoubleDeltas,
Hoon9901,
jadru,
KyeongYeongDEV,
mjh000526,
MoonSangWon and
ShinJongUng
Hoon9901
approved these changes
Nov 2, 2022
| public List<Post> search(@PathVariable String postAuthor, HttpServletResponse response){ | ||
| try{ | ||
| List <Post> post = postService.search(postAuthor); | ||
| if(!post.isEmpty()) { response.setStatus(HttpServletResponse.SC_OK); |
There was a problem hiding this comment.
컨트롤러 단에서 예외 처리도 하나의 비즈니스 로직이라
서비스 단에서 exception throw를 하고 호출 메소드에서
try-catch 하는거를 추천!
| List <Post> post = postService.search(postAuthor); | ||
| if(!post.isEmpty()) { response.setStatus(HttpServletResponse.SC_OK); | ||
| return post; | ||
| } |
There was a problem hiding this comment.
API를 호출하는 입장에서 post가 존재하지 않으면
400으로 code 보는것은 글이 없는건지? 서버 내부 에러인건지 모호해서
not found error를 던져서
“글이 없다는것”을 알려주는게 좋을듯
| //postService.update(postDto); | ||
| try{ | ||
| Optional <Post> post = Optional.ofNullable(postService.save(postDto)); | ||
| if(post.isPresent()){response.setStatus(HttpServletResponse.SC_OK); |
| @GetMapping("/delete/{postAuthor}") //삭제 기능 | ||
| public void delete(@PathVariable String postAuthor, HttpServletResponse response){ | ||
| try{ | ||
| if(postService.delete(postAuthor)) response.setStatus(HttpServletResponse.SC_BAD_REQUEST); |
There was a problem hiding this comment.
이 부분에서 글 삭제가 정상적으로 처리되면
http 상태 코드를 400으로 던지는데
의도한 처리인지?
There was a problem hiding this comment.
httpServletResponse 말고 responseEntity에서 https 로 상태 던집시다.
There was a problem hiding this comment.
네 다음 기능구현때 사용해 보겠습니다!
| if(postService.delete(postAuthor)) response.setStatus(HttpServletResponse.SC_BAD_REQUEST); | ||
| } | ||
| catch (Exception e){ | ||
| response.setStatus(HttpServletResponse.SC_OK); |
| private String postImage; | ||
|
|
||
| public void setPostId(Long postId) { | ||
| this.postId = postId; |
There was a problem hiding this comment.
setter, getter 롬복 어노테이션 추천
그런데 실무에서는 lombok 사용에 대해 고민해봐야함..
| import javax.persistence.Id; | ||
| import java.util.Date; | ||
|
|
||
| @Getter |
| public class Member { | ||
| @Id | ||
| @Column(name = "Id") | ||
| private String Member_id; |
There was a problem hiding this comment.
어 저는 Post (DTO, DAO)만 건들여서 그쪽만 봐주실 수 있을까요?
MoonSangWon
approved these changes
Nov 4, 2022
완료했습니다. [#8]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test구현 예정입니다. 예외처리 한 번 봐주시면 감사하겠습니다
[#8]