Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ts issue with dynamic slots #255

Conversation

inkbeard
Copy link
Owner

@inkbeard inkbeard commented Mar 9, 2024

Change-Id: I888849392145a807608878031139760099fdb238

PR Notes
Got this workaround for the dynamic slots from vuejs/core#5312 (comment).

Change-Id: I888849392145a807608878031139760099fdb238
@inkbeard
Copy link
Owner Author

inkbeard commented Mar 9, 2024

This pull request is part of a stack:

  1. fixed ts issue with dynamic slots (#255)
  2. added deploy preview as a ci_success condition (#256)

Copy link

changeset-bot bot commented Mar 9, 2024

🦋 Changeset detected

Latest commit: 3598b71

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@inkbeard/ui-vue Minor
inkbeard Patch
ui-library Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

netlify bot commented Mar 9, 2024

Deploy Preview for dainty-arithmetic-94f385 ready!

Name Link
🔨 Latest commit 3598b71
🔍 Latest deploy log https://app.netlify.com/sites/dainty-arithmetic-94f385/deploys/65ec7b186e6ab40008236431
😎 Deploy Preview https://deploy-preview-255--dainty-arithmetic-94f385.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mergify mergify bot added the PR stack PR is part of a set of stacked PRs. label Mar 9, 2024
@inkbeard inkbeard added the Ready to merge PR is ready to be merged by mergify. label Mar 9, 2024
@mergify mergify bot merged commit 311826f into main Mar 9, 2024
8 checks passed
@mergify mergify bot deleted the mergify_cli/dynamicSlots/I888849392145a807608878031139760099fdb238 branch March 9, 2024 15:13
@@ -5,6 +5,9 @@
defineOptions({
inheritAttrs: false,
});
defineSlots<{
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually needed but I forgot it while debugging....PR to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR stack PR is part of a set of stacked PRs. Ready to merge PR is ready to be merged by mergify.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant