Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make INNGEST_ALLOW_IN_BAND_SYNC opt out #820

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

amh4r
Copy link
Contributor

@amh4r amh4r commented Jan 27, 2025

Summary

Make INNGEST_ALLOW_IN_BAND_SYNC opt out. This means that the SDK will perform an in-band sync if the Inngest server tells it to, except when INNGEST_ALLOW_IN_BAND_SYNC is explicitly set to a falsy value.

@amh4r amh4r requested a review from jpwilliams January 27, 2025 16:20
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: 757cbc5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Jan 27, 2025
@jpwilliams jpwilliams self-assigned this Jan 27, 2025
@jpwilliams jpwilliams added the ⬆️ improvement Performance, reliability, or usability improvements label Jan 27, 2025
@amh4r amh4r merged commit cb02190 into main Jan 28, 2025
51 checks passed
@amh4r amh4r deleted the INNGEST_ALLOW_IN_BAND_SYNC-opt-out branch January 28, 2025 15:00
jpwilliams pushed a commit that referenced this pull request Jan 28, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Minor Changes

- [#820](#820)
[`cb02190`](cb02190)
Thanks [@amh4r](https://github.com/amh4r)! - Make
INNGEST_ALLOW_IN_BAND_SYNC opt out

- [#813](#813)
[`f42ab05`](f42ab05)
Thanks [@BrunoScheufler](https://github.com/BrunoScheufler)! - Add
initial `connect()` support

### Patch Changes

- [#818](#818)
[`c99b05f`](c99b05f)
Thanks [@BrunoScheufler](https://github.com/BrunoScheufler)! - Add
reconnection support to `connect()`

- [#819](#819)
[`7a5f4a5`](7a5f4a5)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Set `inngest`'s
ALS in global state to be able access it across versions and package
boundaries

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⬆️ improvement Performance, reliability, or usability improvements 📦 inngest Affects the `inngest` package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants