Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE] HOTFIX : 공유 코드 횟수제한 초과 시 에러 수정 #1660

Merged
merged 28 commits into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
a024b4f
[BE] HOTFIX : 연장권 발급 시 used_at을 구매시각으로 지정
chyo1 Jul 8, 2024
00f5145
FIX: 유저Entity 내의 코인 컬럼 명세 제거
saewoo1 Jul 9, 2024
4116707
[BE] FIX: local config refresh
enaenen Jul 9, 2024
6a41015
Merge branch 'dev' of https://github.com/innovationacademy-kr/Cabi in…
enaenen Jul 9, 2024
00f6dc5
[FE] DOCS: SlackAlarm.ts에 있는 템플릿 메시지 white space 수정
jnkeniaem Jul 9, 2024
cee4a2a
[FE] FEAT: 자주쓰는 버튼들 호버뿐만아니라 클릭시에도 css 적용#1652
jnkeniaem Jul 9, 2024
6307ad9
[FE] DOCS: SlackAlarm.ts 템플릿 메시지 white space 추가 수정
jnkeniaem Jul 9, 2024
b2c7e56
[FE] REFACT: store 관련 모달 StoreModal로 이동#1652
jnkeniaem Jul 9, 2024
6104966
[FE] FIX: 템플릿 버튼 누를때 channelBtnIdx가 아닌 templateBtnIdx로 비교하도록 교체#1652
jnkeniaem Jul 9, 2024
64ca01b
[FE] REFACT: 템플릿 버튼 누르거나 hover 일때의 스타일을 담는 hoverAndClickedBtnStyles 변…
jnkeniaem Jul 9, 2024
e89bc77
Merge pull request #1653 from innovationacademy-kr/fe/dev/fix_admin_s…
jnkeniaem Jul 9, 2024
0b187e5
[FE] DOCS: github issue UI 개선창구 템플릿 작성
jnkeniaem Jul 16, 2024
d45d03b
[BE] FIX: config - swap limit 7days -> 1days
enaenen Jul 16, 2024
6221ad6
[BE] HOTFIX: Share ban limit message fixed ( unbanned_at deleted)
enaenen Jul 16, 2024
18d72f4
[FE] DOCS: ui 개선 템플릿 문구 수정
jnkeniaem Jul 16, 2024
6acb727
[COMMON] DOCS: readme에 saymyname 과제 수행 및 이름 추가
jihyunk03 Jul 16, 2024
33cb2de
[COMMON] DOCS: README 이름 추가
seonmiki Jul 16, 2024
67040c8
[COMMON] DOCS: README에 junsbae 추가 #1656
wet6123 Jul 16, 2024
523e8b0
[COMMON] DOCS: readme에 saymyname 계정정보 수정
jihyunk03 Jul 16, 2024
e91f0bf
Merge pull request #1658 from innovationacademy-kr/common/dev/docs_on…
jihyunk03 Jul 16, 2024
90b9ff7
[COMMON] ETC: json 파일 복원
seonmiki Jul 16, 2024
ad82794
Merge branch 'dev' into common/dev/docs_onboarding_saymyname/#1655
seonmiki Jul 16, 2024
471e884
[BE] HOTFIX: Share Ban bug fix (session reset issue)
enaenen Jul 16, 2024
207a42f
Merge remote-tracking branch 'origin/dev' into dev
enaenen Jul 16, 2024
3b566ec
Merge pull request #1657 from innovationacademy-kr/common/dev/docs_on…
seonmiki Jul 16, 2024
cb9bbb0
Merge branch 'dev' into common/dev/docs_onbrarding_saymyname/#1656
wet6123 Jul 16, 2024
1743e50
Merge pull request #1659 from innovationacademy-kr/common/dev/docs_on…
wet6123 Jul 16, 2024
ebcedb3
[BE] HOTFIX : 공유 사물함 대여 시 공유 코드 3번 틀린 경우, redis userSession 삭제
chyo1 Jul 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions .github/ISSUE_TEMPLATE/ui_improvement.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
name: "UI 개선 건의"
description: UI 개선 건의 작성 기본 양식입니다.
labels: ["ui"]
body:
- type: markdown
attributes:
value: |
작성 예시 : "[FE] 지도-E/V 버튼 눌렀을때 나타나는 로고 색 다크모드 적용"
- type: textarea
id: ui-description
attributes:
label: UI 문제점 설명
description: 문제가 언제/어떻게 발생했는지 명확하게 적어주세요.
placeholder: 설명을 적어주세요.
validations:
required: true
- type: textarea
id: reproduction
attributes:
label: 재현 방법
description: 문제가 재현되는 상황을 설명해주세요.
placeholder: 설명을 적어주세요.
validations:
required: true
- type: textarea
id: improvement
attributes:
label: 기대하는 UI
description: 기대하는 UI에 대해서 설명해주세요.
placeholder: 설명을 적어주세요.
validations:
required: true
- type: textarea
id: system-info
attributes:
label: 시스템 환경 (선택 사항)
description: 현재 버그가 발생한 시스템 환경을 적어주세요.
render: shell
placeholder: OS, 브라우저 등을 적어주세요.
validations:
required: false
- type: textarea
id: additional-context
attributes:
label: 추가 건의사항
description: Cabi에 바라시는 점이나, 하시고 싶은 말씀을 적어주세요.
5 changes: 4 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,8 +75,8 @@
<br/>

## 🕸️ 인프라 구조도
![Untitled](https://github.com/innovationacademy-kr/Cabi/assets/83565255/165c1529-6164-4988-9495-6bc2ba3ef0ab)

![Untitled](https://github.com/innovationacademy-kr/Cabi/assets/83565255/165c1529-6164-4988-9495-6bc2ba3ef0ab)

## 🛠 기술 스택

Expand Down Expand Up @@ -175,6 +175,9 @@
| [ 🐶 surlee](https://github.com/Elineely) | [ 🐣 hyowchoi](https://github.com/chyo1/) | [ 👽 sohyupar](https://github.com/saewoo1) | [🦝 jimchoi](https://github.com/jimchoi9) | [ 🛼 jeekim](https://github.com/jnkeniaem) | [🍾 miyu](https://github.com/Minkyu01) | [🧸 gykoh](https://github.com/gykoh42) |
| ----------------------------------------- | ----------------------------------------- | ------------------------------------------ | ----------------------------------------- | ------------------------------------------ | -------------------------------------- | -------------------------------------- |

| [ 🐰 jihykim2](https://github.com/jihyunk03) | [⛄️ seonmiki](https://github.com/seonmiki) | [ 🎱 junsbae ](https://github.com/wet6123) |
| -------------------------------------------- | ------------------------------------------- | ------------------------------------------ |

| <a href="https://github.com/innovationacademy-kr"><img src="https://img.shields.io/badge/42Seoul-000000?style=flat-square&logo=42&logoColor=white" /></a> |
| --------------------------------------------------------------------------------------------------------------------------------------------------------- |

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ public CoinCollectionRewardResponseDto collectCoinAndIssueReward(Long userId) {
// DB에 코인 저장
Item coinCollect = itemQueryService.getBySku(Sku.COIN_COLLECT);
int reward = (int) (coinCollect.getPrice().longValue());
itemHistoryCommandService.createCoinCollectItemHistory(userId, coinCollect.getId());
itemHistoryCommandService.createCoinItemHistory(userId, coinCollect.getId());

// 출석 일자에 따른 랜덤 리워드 지급
Long coinCollectionCountInMonth =
Expand All @@ -203,7 +203,7 @@ public CoinCollectionRewardResponseDto collectCoinAndIssueReward(Long userId) {
Sku coinSku = itemPolicyService.getRewardSku(randomPercentage);
Item coinReward = itemQueryService.getBySku(coinSku);

itemHistoryCommandService.createCoinCollectItemHistory(userId, coinReward.getId());
itemHistoryCommandService.createCoinItemHistory(userId, coinReward.getId());
reward += coinReward.getPrice();
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public void createItemHistories(List<Long> userIds, Long itemId, LocalDateTime u
itemHistoryRepository.saveAll(itemHistories);
}

public void createCoinCollectItemHistory(Long userId, Long itemId) {
public void createCoinItemHistory(Long userId, Long itemId) {
ItemHistory coinCollectItemHistory = ItemHistory.of(userId, itemId, LocalDateTime.now());
itemHistoryRepository.save(coinCollectItemHistory);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,7 @@ private void handlePolicyStatus(LentPolicyStatus status, LocalDateTime policyDat
throw new CustomExceptionStatus(ExceptionStatus.ALL_BANNED_USER,
unbannedAtString).asCustomServiceException();
case SHARE_BANNED_USER:
unbannedAtString = policyDate.format(
DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm"));
throw new CustomExceptionStatus(ExceptionStatus.SHARE_CODE_TRIAL_EXCEEDED,
unbannedAtString).asCustomServiceException();
throw ExceptionStatus.SHARE_CODE_TRIAL_EXCEEDED.asServiceException();
case BLACKHOLED_USER:
throw ExceptionStatus.BLACKHOLED_USER.asServiceException();
case PENDING_CABINET:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,8 @@ public void deleteUserInCabinet(Long cabinetId, Long userId) {
lentRedis.deleteUserInCabinet(cabinetIdString, userIdString);
if (lentRedis.countUserInCabinet(cabinetIdString) == 0) {
lentRedis.deleteShadowKey(cabinetIdString);
clearCabinetSession(cabinetId);

}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public class User {
private boolean pushAlarm;

@NotNull
@Column(name = "COIN", columnDefinition = "bigint default 0")
@Column(name = "COIN")
private Long coin;

protected User(String name, String email, LocalDateTime blackholedAt) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ public void issueLentExtension() {
users.forEach(user -> {
Long userId = user.getId();
user.addCoin(coinRewardItem.getPrice());
itemHistoryCommandService.createItemHistory(userId, coinRewardItem.getId());
itemHistoryCommandService.createCoinItemHistory(userId, coinRewardItem.getId());
});
}

Expand Down
2 changes: 1 addition & 1 deletion config
Loading
Loading