Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: static content assets directory #4775

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Schwehn42
Copy link
Collaborator

@Schwehn42 Schwehn42 commented Jan 14, 2025

Description

Resolves #4736

Changelog

  • Move timer_finished.mp3 and hotkeys.pdf from public to public/assets
  • Adjust path refs
  • add paths to Caddy and Traefik configs

to $public/assets/
@Schwehn42 Schwehn42 self-assigned this Jan 14, 2025

This comment has been minimized.

This comment has been minimized.

nginx.conf Outdated Show resolved Hide resolved

This comment has been minimized.

This comment has been minimized.

@Schwehn42
Copy link
Collaborator Author

Q: is /assets or /static better fitting?

@Schwehn42 Schwehn42 added the Review Needed This pull request is ready for review label Jan 16, 2025
@brandstetterm
Copy link
Collaborator

Q: is /assets or /static better fitting?

Fine with both

Copy link

The deployment to the dev cluster was successful. You can find the deployment here: https://4775.development.scrumlr.fra.ics.inovex.io
This deployment is only for testing purposes and will be deleted after 1 week.
To redeploy rerun the workflow.
DO NOT STORE IMPORTANT DATA ON THIS DEPLOYMENT

Deployed Images
  • ghcr.io/inovex/scrumlr.io/scrumlr-frontend:sha-033885f

  • ghcr.io/inovex/scrumlr.io/scrumlr-server:sha-033885f

Copy link

octomind-dev bot commented Jan 17, 2025

🐙 Octomind

Test Report: 14/14 successful.

description status details
About Section Visibility Test Passed ✅ click
change avatar Passed ✅ click
check Privacy Policy Passed ✅ click
check terms & conditions Passed ✅ click
close cookie banner - front page Passed ✅ click
close cookie banner - sign-in Passed ✅ click
create and delete board columns Passed ✅ click
create_and_delete_notes_and_actions_v2 Passed ✅ click
create lean coffee board Passed ✅ click
edit_notes_and_actions_v5 Passed ✅ click
get started Passed ✅ click
share_session Passed ✅ click
sign-in Passed ✅ click
test all ways to open the setup flow Passed ✅ click

commit sha: 033885f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Needed This pull request is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serve static content under dedicated assets route
3 participants