Add hook tests

inpsyde · Jul 29, 2024 · 985ac96 · 985ac96
1 parent bdc0cb7
commit 985ac96
Show file tree

Hide file tree

Showing 3 changed files with 64 additions and 0 deletions.
diff --git a/src/Caching/IgnoreCacheHandler.php b/src/Caching/IgnoreCacheHandler.php
@@ -20,6 +20,13 @@ public function execute(AssetManager $assetManager): void
 
         $assetHandles = $this->extractHandles($assetManager);
 
+        if (
+            count($assetHandles[Script::class]) === 0 &&
+            count($assetHandles[Style::class]) === 0
+        ) {
+            return;
+        }
+
         foreach ($handlers as $ignorePluginHandler) {
             if ($ignorePluginHandler->isInstalled()) {
                 $ignorePluginHandler->apply($assetHandles);

diff --git a/tests/phpunit/Unit/Caching/IgnoreSitegroundCacheTest.php b/tests/phpunit/Unit/Caching/IgnoreSitegroundCacheTest.php
@@ -20,6 +20,33 @@
 
 class IgnoreSitegroundCacheTest extends AbstractTestCase
 {
+    public function testIsInstalled()
+    {
+        if (!class_exists('SiteGround_Optimizer\Loader\Loader')) {
+            eval('namespace SiteGround_Optimizer\Loader { class Loader {} }');
+        }
+
+        $ignoreSitegroundCache = new IgnoreSitegroundCache();
+        $this->assertTrue($ignoreSitegroundCache->isInstalled());
+    }
+
+    public function testApply(): void
+    {
+
+        $ignoreSitegroundCache = new IgnoreSitegroundCache();
+        $ignoreSitegroundCache->apply([]);
+
+        self::assertNotFalse(has_filter('sgo_js_minify_exclude', 'function (array $scripts)'));
+        self::assertNotFalse(
+            has_filter(
+                'sgo_javascript_combine_exclude',
+                'function (array $scripts)'
+            )
+        );
+        self::assertNotFalse(has_filter('sgo_css_minify_exclude', 'function (array $styles)'));
+        self::assertNotFalse(has_filter('sgo_css_combine_exclude', 'function (array $styles)'));
+    }
+
     public function testApplyExcludedHandlers(): void
     {
         $excluded = ['excluded-1', 'excluded-2'];

diff --git a/tests/phpunit/Unit/Caching/IgnoreW3TotalCacheTest.php b/tests/phpunit/Unit/Caching/IgnoreW3TotalCacheTest.php
@@ -13,13 +13,43 @@
 
 namespace Inpsyde\Assets\Tests\Unit\Caching;
 
+use Inpsyde\Assets\Caching\IgnoreSitegroundCache;
 use Inpsyde\Assets\Caching\IgnoreW3TotalCache;
 use Inpsyde\Assets\Tests\Unit\AbstractTestCase;
 
 use function PHPUnit\Framework\assertSame;
 
 class IgnoreW3TotalCacheTest extends AbstractTestCase
 {
+    public function testIsInstalled(): void
+    {
+        if (!class_exists('W3TC\Root_Loader')) {
+            eval('namespace W3TC { class Root_Loader {} }');
+        }
+
+        $IgnoreW3TotalCache = new IgnoreW3TotalCache();
+        $this->assertTrue($IgnoreW3TotalCache->isInstalled());
+    }
+    public function testApply(): void
+    {
+
+        $ignoreSitegroundCache = new IgnoreW3TotalCache();
+        $ignoreSitegroundCache->apply([]);
+
+        self::assertNotFalse(
+            has_filter(
+                'w3tc_minify_js_do_tag_minification',
+                'function (bool $doMinification, string $scriptTag)'
+            )
+        );
+        self::assertNotFalse(
+            has_filter(
+                'w3tc_minify_css_do_tag_minification',
+                'function (bool $doMinification, string $scriptTag)'
+            )
+        );
+    }
+
     public function testDetermineMinification(): void
     {
         $scriptTag = '<script src="example.js" id="assets-plugin-script-js"></script>';