Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Documentation and logic fix.
What is the current behavior? (You can also link to an open issue here)
Documentation introduced in #81 PR leads to the broken behavior. Custom Inpsyde sniffs and sniffs imported in the Insyde ruleset are not applied to the
templates
directory if the package configuration file contains the following:What is the new behavior (if this is a feature change)?
I double-checked different options and asked for PHPCS maintainers' support (see PHPCSStandards/PHP_CodeSniffer#380), but apparently, PHPCS doesn't support what we need right now. I.e.,
exclude-pattern
andinclude-pattern
are applied globally (andexclude
has priority).It means disabling any of the
Inpsyde
rules from theInpsydeTemplates
ruleset is impossible. So, we have to come back to the initial suggestion:This way, the whole project will be checked with
Inpsyde
CS, andtemplates
andviews
directories will also be checked withInpsydeTemplates
CS. If someone needs to excludeNoElse
or any rule, they should do it explicitly in the project configuration.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
It's rather a bug fix.
Other information: