Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new workflow to run Playwright tests #177

Merged
merged 40 commits into from
Feb 7, 2025
Merged

Add new workflow to run Playwright tests #177

merged 40 commits into from
Feb 7, 2025

Conversation

dottxado
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

What is the current behavior? (You can also link to an open issue here)

We miss a reusable workflow to run Playwright tests. Closes #173

What is the new behavior (if this is a feature change)?

Add a new workflow to run Playwright tests.

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information:

@dottxado dottxado requested a review from a team as a code owner January 30, 2025 14:19
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Left a couple of relatively minor comments and suggestions. 😉

@dottxado dottxado requested a review from tyrann0us February 6, 2025 11:00
Copy link
Member

@tyrann0us tyrann0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for incorporating all the changes! 🙏🏽 There are only two very minor suggestions left that don't stop me from approving. Great job! 💪🏽

@dottxado dottxado merged commit ce6c3b2 into main Feb 7, 2025
3 checks passed
@dottxado dottxado deleted the run-script branch February 7, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Workflow for automated tests
2 participants