FIX: Remove potentially leaky continuation passing of EKGForwarder
#34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coot
reviewed
Sep 18, 2024
Comment on lines
+47
to
+49
| MsgReq req -> Effect $ do | ||
| resp <- recvMsgReq req | ||
| return $ Yield (ServerAgency TokBusy) (MsgResp resp) go |
There was a problem hiding this comment.
This doesn't really change when resp is evaluated to WHNF, maybe you'd like to add a !?
There was a problem hiding this comment.
Does that really change anything?
resphasn't shown to be leakyrespis basically a[(MetricName, MetricValue)], so eval'ing to WHNF here wouldn't make much difference- the list gets always fully evaluated when the response is sent over the wire
However, if you think it makes a difference, I can add the bang - you decide.
There was a problem hiding this comment.
That's fine then. Thanks @mgmeier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix space leaks that have presented themselves during info table profiling (see attachment):
EKGForwardconstructor - in the module indicated by the profiling resultsrecvMsgDone/ leaking()thunksAdditionally, package dependencies are bumped (
typed-protocols~ 0.1.1 andouroboros-network-framework~ 0.13.x) and maintenance info is updated.