-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle curl failure #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sensible.
What are we doing about the CI here? Re-evaluating doesn't seem to be having any effect :think |
I've asked @cleverca22 for some help. I need to get some windows idiocity done before I can focus on something else :-( |
78140d8
to
b3e8d6f
Compare
As we discovered, curl does not fail on http response codes >=400 by default.
This PR:
--fail
to curl's flags--write-out
to obtain a decent error messageSample output: