Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kube deploy refactor #679

Merged
merged 15 commits into from
Aug 9, 2023
Merged

Kube deploy refactor #679

merged 15 commits into from
Aug 9, 2023

Conversation

ce0la
Copy link
Contributor

@ce0la ce0la commented Aug 4, 2023

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Test report is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • Self-reviewed the diff
    • Useful pull request description
      • Review required
      • Substantial changes to code, test, or documentation
      • Change made to Marlowe validator (@bwbush and @palas must be included as reviewers)
      • Review not required
      • Minor changes to non-critical code, documentation, nix derivations, configuration files, or scripts
      • Formatting, spelling, grammar, or reorganization
    • Reviewer requested

@ce0la ce0la requested a review from shlevy August 7, 2023 12:30
@ce0la ce0la added the No Changelog Required Turns of the check-changelog check label Aug 8, 2023
annotations:
app.oam.dev/publishVersion: {{ $.Chart.AppVersion }}
meta.helm.sh/release-name: {{ $.Values.releaseName }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are these needed? What do they mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deployments were failing without the annotations being present; seems they are for KubeVela to track Helm deployments.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any documentation on them? Is this why chart changes weren't always propagating?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is why chart changes weren't propagating. There are no documentations in Kubevela itself, but this SO answer captures an explanation for it: https://stackoverflow.com/a/69005327

@@ -35,7 +37,7 @@ spec:
- type: https-route
properties:
domains:
- marlowe-runtime-{{ . }}-web.scdev.aws.iohkdev.io
- marlowe-runtime-{{ . }}-refactor-web.scdev.aws.iohkdev.io
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we remove this now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will update the values now.

repo: ghcr.io
org: input-output-hk

namespace: marlowe-staging-refactor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Back to marlowe-staging?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

@ce0la ce0la merged commit 4cc7f88 into kube-deploy Aug 9, 2023
1 check passed
@ce0la ce0la deleted the kube-deploy-refactor branch August 9, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Turns of the check-changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants