Kube deploy refactor #679
Merged
Kube deploy refactor #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ce0la
force-pushed
the
kube-deploy-refactor
branch
from
3bc95aa
to
85364a0
Compare
ce0la
force-pushed
the
kube-deploy-refactor
branch
from
48ee010
to
6883d4c
Compare
shlevy
approved these changes
Aug 9, 2023
| annotations: | ||
| app.oam.dev/publishVersion: {{ $.Chart.AppVersion }} | ||
| meta.helm.sh/release-name: {{ $.Values.releaseName }} |
There was a problem hiding this comment.
Why are these needed? What do they mean?
There was a problem hiding this comment.
The deployments were failing without the annotations being present; seems they are for KubeVela to track Helm deployments.
There was a problem hiding this comment.
Is there any documentation on them? Is this why chart changes weren't always propagating?
There was a problem hiding this comment.
I don't think that is why chart changes weren't propagating. There are no documentations in Kubevela itself, but this SO answer captures an explanation for it: https://stackoverflow.com/a/69005327
| @@ -35,7 +37,7 @@ spec: | |||
| - type: https-route | |||
| properties: | |||
| domains: | |||
| - marlowe-runtime-{{ . }}-web.scdev.aws.iohkdev.io | |||
| - marlowe-runtime-{{ . }}-refactor-web.scdev.aws.iohkdev.io | |||
There was a problem hiding this comment.
Yes, I will update the values now.
deploy/marlowe-runtime/values.yaml
Outdated
| repo: ghcr.io | ||
| org: input-output-hk | ||
|
|
||
| namespace: marlowe-staging-refactor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-submit checklist: