Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused SC param fields #122

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

chore: remove unused SC param fields #122

wants to merge 1 commit into from

Conversation

kpinter-iohk
Copy link
Contributor

Description

Exploratory work on the effect of removing unused fields chainId, thresholdNumerator and thresholdDenominator from SidechainParameters.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

@AmbientTea
Copy link
Contributor

Is this PR still relevant? If not let's close it

@kpinter-iohk
Copy link
Contributor Author

@AmbientTea I would like to get this in but the discussion stalled on it and we were busy with other stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kpinter-iohk @AmbientTea