Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/e2e-tests add e2e tests from sidechains-tests repository #162

Open
wants to merge 31 commits into
base: master
Choose a base branch
from

Conversation

ladamesny
Copy link
Contributor

@ladamesny ladamesny commented Oct 16, 2024

Description

Add your description here, if it fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

@ladamesny ladamesny self-assigned this Oct 16, 2024
@ladamesny ladamesny added the E2E-tests E2E Tests for SDET review/approval label Oct 16, 2024
@ladamesny ladamesny marked this pull request as ready for review October 21, 2024 16:28
dev/local-environment/docker-compose.yml Outdated Show resolved Hide resolved
dev/local-environment/.env Outdated Show resolved Hide resolved
Copy link
Contributor

@chrispalaskas chrispalaskas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait for Dev and SET approvals as well.

"scheme": "ECDSA",
"address": "5C7C2Z5sWbytvHpuLTvzKunnnRwQxft1jiqrLD5rhucQ5S9X",
"secret_seed": "cb6df9de1efca7a3998a8ead4e02159d5fa99c3e0d4fd6432667390bb4726854",
"public_key": "020a1091341fe5664bfa1782d5e04779689068c916b04cb365ec3153755684d9a1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using this key in other envs already, please replace with a new one that will be used only for the local env. It also needs to be replaced on partner-chains/dev/local-environment/configurations/partner-chains-nodes/partner-chains-node-1/keys/sidechain.vkey. Perhaps it makes more sense to replace the other instances we use it (devnet) since this key is already compromised from the PC demo.

"secret_seed": "cb6df9de1efca7a3998a8ead4e02159d5fa99c3e0d4fd6432667390bb4726854",
"public_key": "020a1091341fe5664bfa1782d5e04779689068c916b04cb365ec3153755684d9a1"
},
"active-flow": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 3 keys can be removed, we don't have active flow, nor passive and nor negative.

@ladamesny ladamesny force-pushed the feature/e2e-tests branch 2 times, most recently from 72195c7 to 5ae5c65 Compare October 24, 2024 22:10
Comment on lines +3 to +4
slack_webhook_url=$SLACK_WEBHOOK_URL
jira_url=$JIRA_URL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add these to repo secrets

@@ -0,0 +1,29 @@
( # DAVE
'0x039799ff93d184146deacaa455dade51b13ed16f23cdad11d1ad6af20103391180',
{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure - I removed it - I think this was a temp file I brought over from the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2E-tests E2E Tests for SDET review/approval
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants