Feature/e2e-tests add e2e tests from sidechains-tests repository #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladamesny
force-pushed
the
feature/e2e-tests
branch
from
e441dff
to
caaecb5
Compare
ladamesny
force-pushed
the
feature/e2e-tests
branch
from
6a01b9e
to
08cb3ff
Compare
chrispalaskas
requested changes
Oct 21, 2024
chrispalaskas
approved these changes
Oct 21, 2024
LGLO
reviewed
Oct 21, 2024
LGLO
approved these changes
Oct 21, 2024
E2E-tests/secrets/substrate/demo/keys/dave/partner_chain.skey.json
Outdated
Show resolved
Hide resolved
chrispalaskas
requested changes
Oct 21, 2024
E2E-tests/secrets/substrate/local/keys/alice/partner_chain.skey.json
Outdated
Show resolved
Hide resolved
LGLO
reviewed
Oct 22, 2024
LGLO
reviewed
Oct 22, 2024
ladamesny
force-pushed
the
feature/e2e-tests
branch
from
c2585b4
to
ef22f1f
Compare
chrispalaskas
requested changes
Oct 22, 2024
| "scheme": "ECDSA", | ||
| "address": "5C7C2Z5sWbytvHpuLTvzKunnnRwQxft1jiqrLD5rhucQ5S9X", | ||
| "secret_seed": "cb6df9de1efca7a3998a8ead4e02159d5fa99c3e0d4fd6432667390bb4726854", | ||
| "public_key": "020a1091341fe5664bfa1782d5e04779689068c916b04cb365ec3153755684d9a1" |
There was a problem hiding this comment.
We are using this key in other envs already, please replace with a new one that will be used only for the local env. It also needs to be replaced on partner-chains/dev/local-environment/configurations/partner-chains-nodes/partner-chains-node-1/keys/sidechain.vkey. Perhaps it makes more sense to replace the other instances we use it (devnet) since this key is already compromised from the PC demo.
| "secret_seed": "cb6df9de1efca7a3998a8ead4e02159d5fa99c3e0d4fd6432667390bb4726854", | ||
| "public_key": "020a1091341fe5664bfa1782d5e04779689068c916b04cb365ec3153755684d9a1" | ||
| }, | ||
| "active-flow": { |
There was a problem hiding this comment.
These 3 keys can be removed, we don't have active flow, nor passive and nor negative.
AmbientTea
approved these changes
Oct 23, 2024
ladamesny
force-pushed
the
feature/e2e-tests
branch
2 times, most recently
from
72195c7
to
5ae5c65
Compare
rsporny
reviewed
Oct 25, 2024
Comment on lines
+3
to
+4
| slack_webhook_url=$SLACK_WEBHOOK_URL | ||
| jira_url=$JIRA_URL |
There was a problem hiding this comment.
we need to add these to repo secrets
E2E-tests/src/temp.py
Outdated
| @@ -0,0 +1,29 @@ | |||
| ( # DAVE | |||
| '0x039799ff93d184146deacaa455dade51b13ed16f23cdad11d1ad6af20103391180', | |||
| { | |||
There was a problem hiding this comment.
not sure - I removed it - I think this was a temp file I brought over from the repo.
ladamesny
force-pushed
the
feature/e2e-tests
branch
from
5ae5c65
to
d225181
Compare
ladamesny
force-pushed
the
feature/e2e-tests
branch
from
604b715
to
943c75f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add your description here, if it fixes a particular issue please provide a
link
to the issue.
Checklist
changelog.mdfor affected crateNote on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.