Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: ETCM-8722 parse datums V0 #196

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

AmbientTea
Copy link
Contributor

@AmbientTea AmbientTea commented Oct 29, 2024

Description

  • Adds parsing of versioned datums of schema version 0, equivalent to the legacy schema
  • Adds general framework for parsing versioned datums via VersionedDatum trait

The tests cases are taken from the golden tests in smart contracts repo. Once the smart contracts changes are merged, I will verify with local chain and real plutus data on preview before merging this PR.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages.
  • New tests are added if needed and existing tests are updated.
  • Relevant logging and metrics added
  • CI passes. See note on CI.
  • Any changes are noted in the changelog.md for affected crate
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG Partner Chains developers to do this
for you.

Signed-off-by: Nikolaos Dymitriadis <[email protected]>
@AmbientTea AmbientTea marked this pull request as ready for review October 29, 2024 13:12
/// Trait that provides decoding of versioned generic plutus data.
///
/// Versioned generic plutus data contain a version number and two data sections:
/// - immutable section - the proper datum with stable schema, read and validated by smart contracts
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other part is as proper as this one. One is read/written by smart-contracts the other is not used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants