feat: adds sidechain_main_cli into config file instead
#64
+94
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a new constant `sidechain_main_cli_name` with value `sidechain-main-cli`
- change the assignment of `sidechain_main_cli_path` to include `{sidechain_main_cli_name}`
- update the `load_chain_config` function to load `sidechain_main_cli` from file
- add a new constant `sidechain_main_cli` with default value `sidechain_main_cli_path`
- add a new function `which` in the `iocontext` trait
- update the `defaultcmdruncontext` implementation of `iocontext` to include the `which` function
- add a new file `io.rs` with changes for `which` and its implementation in `defaultcmdruncontext`
- modify the `prepare_main_chain_config` function to use `sidechain_main_cli_name` instead of `sidechain_main_cli_path`
- update the `run_sidechain_main_cli_addresses` function to load `sidechain_main_cli` from file
- change the command in the `addresses_cmd` function to include `sidechain_cli_path`
- replace `sidechain_main_cli_path` with `sidechain_exec` in error messages and commands
- update the `sidechain_main_cli_version_cmd` to use `{sidechain_main_cli_path}`
- modify the `sidechain_main_cli_version_cmd` and `sidechain_main_cli_version_prompt` functions to use `sidechain_exec` instead of `sidechain_main_cli_path`
falcucci
changed the title
load_chain_config function to load sidechain_main_cli from config file insteadsidechain_main_cli into config file instead
- remove the `println!` statement that logged the `sidechain_exec` variable
- add initialization for `sidechain_exec` variable
- adjust the `command` format string by removing `{sidechain_main_cli_path}`
- update the format string with `{}` instead of `{sidechain_main_cli_path}`
- update the `config_fields::sidechain_main_cli` loading process
- add loading of sidechain cli executable from configuration file - update command format to include sidechain cli executable - fix a typo in the error message text - adjust line numbers in the set_d_parameter_on_main_chain function
…i key - remove `sidechain_main_cli_name` constant - update `sidechain_main_cli_path` constant definition - adjust calls to `sidechain_main_cli_version_prompt` function to include `sidechain_main_cli_path` - add `sidechain_main_cli` key to resource config content - edit resource config content to include `sidechain_main_cli` key - update `mockio::print` call to include multiple items - edit resource config content to include `sidechain_main_cli` key - add `sidechain_main_cli` key to resource config content - edit resource config content to include `sidechain_main_cli` key - implement `which` method in `iocontext` - adjust `promptyn` mock action in `iocontext` for `mockiocontext`
- update error messages in multiple functions for missing partner chains smart contracts executable file - remove loading of sidechain executable in `prepare_main_chain_config` - consolidate error message generation for missing sidechain executable in multiple functions - add `debug` trait implementation for `mockiocontext` struct
|
@falcucci Thank you for your contribution! Having the path to smart-contracts CLI (sorry for the current cryptic name) hardcoded in partner-chains-cli tool was a decision, it was not just because it is easier to implement. The biggest factor to make this decision was to make it hard to use versions of |
|
@LGLO hey, thank you for the explanation. that's fine this is a take it or leave it change, once I am using for personal purposes during development part of the walk-through setup of the partner-chain. Anyway I'll keep this up to date with the upstream changes, so in case the decision changes that's ready and available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we have the sidechain-main-cli binary as an external dependency, would be easier for developers/users to load its binary path from the
partner-chains-cli-resources-config.jsonfile so the user can have it installed in their PATH and update them only if needed but keeping the default one as./sidechain-main-clijust in case.