-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corPFSOS #91
corPFSOS #91
Conversation
@danielinteractive this is the draft for the corPFSOS function, without docu & tests :) |
Unit Test Performance Difference
Additional test case details
Results for commit c3401c7 ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @holgstr , nice work, please see for suggested next steps below
Code Coverage Summary
Diff against main
Results for commit: 2505e0d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
@danielinteractive I have now documented all the functions. The main functions are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @holgstr , let's please separate out the bootstrap part in a new issue and PR. You can still add the corPFSOS
function but still without the bootstrap here
R/corPFSOS.R
Outdated
} | ||
cor_res <- NULL | ||
for (i in seq_len(bootstrap.n)) { | ||
b_sample <- data[sample(nrow(data), replace = TRUE), ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the way the survival bootstrap works? see Kaspar's reference
Co-authored-by: Daniel Sabanes Bove <[email protected]> Signed-off-by: Holger Löwe <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]> Signed-off-by: Holger Löwe <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]> Signed-off-by: Holger Löwe <[email protected]>
Co-authored-by: Daniel Sabanes Bove <[email protected]> Signed-off-by: Holger Löwe <[email protected]>
Fixes #90