-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix mistake in corPFSOS bootstrap #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @holgstr , can you please add a test that first reproduces the error / makes sure it works correctly now?
Unit Test Performance Difference
Additional test case details
Results for commit 0c076cb ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: abdf4a0 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
tests/testthat/test-corPFSOS.R
Outdated
accrual = list(param = "intensity", value = 7) | ||
)[[1]] | ||
actual <- corPFSOS(data, transition = exponential_transition(), bootstrap = FALSE) | ||
expect_equal(actual[[1]], corTrans(transition = transition), tolerance = 1e-2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but this would not be correct?
What you can do e.g. is to write down the correct result you get now and compare with that here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you mean :)
Fixes mistake I found in corPFSOS. We displayed
corTrans()
of initialTransitionParameters
, needcorTrans()
of estimated object instead.