Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

74: closed form calculations for PWCsurvOS #97

Merged
merged 16 commits into from
Dec 7, 2023

Conversation

danielinteractive
Copy link
Collaborator

closes #74

Copy link
Contributor

github-actions bot commented Dec 6, 2023

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  ---------
R/assertions.R                  15       0  100.00%
R/corPFSOS.R                    95      19  80.00%   314-332
R/empSignificant.R              59       0  100.00%
R/estimateParams.R              80       0  100.00%
R/eventTracking.R               88       2  97.73%   48, 244
R/getClinicalTrials.R           71       0  100.00%
R/getSimulatedData.R           109       0  100.00%
R/getWaitTimeSum.R              29       2  93.10%   45, 48
R/hazardFunctions.R             26       0  100.00%
R/piecewiseDistribution.R       32       0  100.00%
R/piecewiseHazards.R            18       0  100.00%
R/survivalFunctions.R          152       0  100.00%
R/transitionParameters.R        42       0  100.00%
TOTAL                          816      23  97.18%

Diff against main

Filename                 Stmts    Miss  Cover
---------------------  -------  ------  --------
R/survivalFunctions.R      +41       0  +100.00%
TOTAL                      +41       0  +0.15%

Results for commit: 45e1544

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Unit Tests Summary

    1 files    16 suites   2m 9s ⏱️
101 tests 100 ✔️ 1 💤 0
224 runs  223 ✔️ 1 💤 0

Results for commit 45e1544.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Dec 6, 2023

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
getClinicalTrials 💚 $4.92$ $-2.15$ $0$ $0$ $0$ $0$
getSimulatedDataDistib 💚 $99.38$ $-4.06$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
getClinicalTrials 💚 $3.58$ $-2.01$ getClinicalTrials_works_as_expected_and_generates_data_according_to_PWC
getSimulatedDataDistib 💚 $36.10$ $-2.58$ getSimulatedData_generates_distributions_as_expected_PW
getSimulatedDataDistib 💚 $51.49$ $-1.11$ getSimulatedData_generates_distributions_as_expected_Weibull
piecewiseHazards 💀 $0.01$ $-0.01$ getPCWHazard_works_as_expected
piecewiseHazards 👶 $+0.03$ getPWCHazard_works_as_expected
survivalFunctions 👶 $+0.01$ PWCsurvOS_does_not_return_values_larger_than_1
survivalFunctions 👶 $+0.03$ PWCsurvOS_gives_equal_results_as_the_numerical_integration
survivalFunctions 👶 $+0.05$ PWCsurvOS_is_monotonically_decreasing_and_not_larger_than_1

Results for commit b7199c0

♻️ This comment has been updated with latest results.

Daniel Sabanes Bove added 2 commits December 6, 2023 15:54
Copy link
Contributor

@holgstr holgstr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielinteractive So cool that this works now, and you even wrote an extensive vignette ;) I just have a very minor suggestion for change in the vignette.

vignettes/pwc_survival.Rmd Outdated Show resolved Hide resolved
@danielinteractive danielinteractive merged commit be10062 into main Dec 7, 2023
25 checks passed
@danielinteractive danielinteractive deleted the 74_pwcsurvos_smooth branch December 7, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PWCsurvOS returns values larger than 1
2 participants