Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata IACS keyword GEMET anchor valid url added #855

Merged
merged 1 commit into from
Nov 4, 2024
Merged

metadata IACS keyword GEMET anchor valid url added #855

merged 1 commit into from
Nov 4, 2024

Conversation

dperezBM
Copy link
Contributor

@dperezBM dperezBM commented Nov 4, 2024

Corresponding issue: #1115

jenriquesoriano
jenriquesoriano approved these changes Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@jenriquesoriano jenriquesoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REviewed OK

@jenriquesoriano jenriquesoriano merged commit fec7f64 into staging Nov 4, 2024
@vbombaerts
Copy link

@jenriquesoriano @dperezBM
I may be wrong but I think the idea was to accept the concept anchor value http://www.eionet.europa.eu/gemet/concept/1600 without language. In the code I see the anchor with http and with https but not without the en language. fec7f64

@vbombaerts vbombaerts mentioned this pull request Nov 4, 2024
Open
fabiovinci
fabiovinci reviewed Nov 6, 2024
View reviewed changes
Copy link
Member

@fabiovinci fabiovinci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional URL should be: http://www.eionet.europa.eu/gemet/concept/1600

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiovinci fabiovinci fabiovinci left review comments

@jenriquesoriano jenriquesoriano jenriquesoriano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dperezBM @vbombaerts @fabiovinci @jenriquesoriano