Upgrade to Rails 5.0 #917
Draft
Upgrade to Rails 5.0 #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't seem to properly relate to the `Layer#fields` and `Collection#sites` association objects from the import wizard, leading to exceptions in ActiveRecord (`persisted.map!` on frozen array), and then the bulk operation to save the sites in elasticsearch to be empty...
This reverts commit 5804abae862c2fa07bd8ff9696c9646ff953435a.
…turning frozen arrays)
This reverts commit d483b84a1caca5578c998c10d408e59b13abe018.
The gems upgraded jquery 1.5 to jquery 1.12 which broke some backward compatibility in v1.9 by removing `$.browser` which is breaking a couple dependencies (fancybox, jcrop) as well as the instedd theme. Let's avoid dealing with frontend matters while upgrading the backend.
Fake it until you can make it.
The includes-count gem has been abandonned and breaks ActiveRecord 5.0 badly (it freezes an internal collection), and it was easier to remove active_model_serializers to replace includes-count than trying to fix the one time usage of the serializer.
ysbaddaden
force-pushed
the
task/upgrade-to-rails50
branch
from
a5af9fd
to
360332b
Compare
Fixes a couple issues found by Knockout 3.5 but still downgrade the library as it still doesn't work properly. Also vendors the asset file as the gem can't be installed along with rails 5 and the gem does nothing. Also downgrades lodash since there was error popping out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begins the upgrade from Rails 4.2 to Rails 5.0
includes-countgem (abandoned, used once, breaks ActiveRecord)active_model_serializersgem (used once along withincludes-count)