-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: SurveyCanceller per survey #2337
Commits on May 9, 2024
-
BROKEN - Fix: start survey cancellator on startup
The Supervisor API expects a set of task descriptions to start, not the actual tasks already started - as we were sending it. This is still broken, since the consumers can't subscribe to the producer if it hasn't started yet - and the app crashes. See #2147
Configuration menu - View commit details
-
Copy full SHA for 021ac91 - Browse repository at this point
Copy the full SHA 021ac91View commit details -
Refactor: SurveyCanceller per survey
Instead of using consumers and producers, upon app startup we launch a single SurveyCanceller process per each survey. We still have to change the "online" behaviour (when we start cancelling a survey while the app is already started). See #2147
Configuration menu - View commit details
-
Copy full SHA for 74d07ab - Browse repository at this point
Copy the full SHA 74d07abView commit details -
WIP - Using new SurveyCanceller from controller
Instead of the old consumers and producers. See #2147
Configuration menu - View commit details
-
Copy full SHA for 8dbe8f8 - Browse repository at this point
Copy the full SHA 8dbe8f8View commit details -
WIP: Simplify SurveyCanceller per survey
Instead of having a producer and consumers, have a single actor per Survey. Still have to fix/refactor the canceller tests. See #2147
Configuration menu - View commit details
-
Copy full SHA for 8919f15 - Browse repository at this point
Copy the full SHA 8919f15View commit details -
Which may not necessarily be about SurveyCanceller, but this will do for the time being. See #2147
Configuration menu - View commit details
-
Copy full SHA for 35d575f - Browse repository at this point
Copy the full SHA 35d575fView commit details -
Configuration menu - View commit details
-
Copy full SHA for fab8f76 - Browse repository at this point
Copy the full SHA fab8f76View commit details -
Don't override exit code and reason after cancel
The exit_code and reason are already being set by the SurveyAction See #2337
Configuration menu - View commit details
-
Copy full SHA for ece0a25 - Browse repository at this point
Copy the full SHA ece0a25View commit details -
Fix SurveyCanceller package and path
We've dropped the "respondents" part of the name long ago, and it's part of the runtime actually. See #2337
Configuration menu - View commit details
-
Copy full SHA for eb87acc - Browse repository at this point
Copy the full SHA eb87accView commit details -
Configuration menu - View commit details
-
Copy full SHA for 25bcb33 - Browse repository at this point
Copy the full SHA 25bcb33View commit details -
Configuration menu - View commit details
-
Copy full SHA for e46eb19 - Browse repository at this point
Copy the full SHA e46eb19View commit details -
Configuration menu - View commit details
-
Copy full SHA for c96c29b - Browse repository at this point
Copy the full SHA c96c29bView commit details -
Fix: check for dispositon changes in tests
Looks like the log entries are getting stored in different order in the CI, which is probably not really an issue. This commit changes how we check for the last disposition change in the tests, so we avoid asserting on a "response" entry log instead. See #2337
Configuration menu - View commit details
-
Copy full SHA for 81ed71e - Browse repository at this point
Copy the full SHA 81ed71eView commit details -
Fix: SurveyBroker tests with log entry order
Doesn't really have to do with the current PR, but are failing anyway
Configuration menu - View commit details
-
Copy full SHA for 03be2a3 - Browse repository at this point
Copy the full SHA 03be2a3View commit details
Commits on May 10, 2024
-
If cancelling a respondent raises an error, we log the issue in Sentry and continue cancelling the rest of them. We keep the survey Cancelling so we wait for human intervention. See #2337
Configuration menu - View commit details
-
Copy full SHA for 58b539f - Browse repository at this point
Copy the full SHA 58b539fView commit details
Commits on May 13, 2024
-
The function effectively marks the survey as terminated - the cancellation is the whole process of managing respondents + the survey. See #2147 See #2337 Co-authored-by: Ana Pérez Ghiglia <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 863e2df - Browse repository at this point
Copy the full SHA 863e2dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0e53c4 - Browse repository at this point
Copy the full SHA a0e53c4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9dc98c3 - Browse repository at this point
Copy the full SHA 9dc98c3View commit details