Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(artifact): add retry in minIO and milvus #109

Merged
merged 1 commit into from
Oct 7, 2024
Merged

feat(artifact): add retry in minIO and milvus #109

merged 1 commit into from
Oct 7, 2024

Conversation

Yougigun
Copy link
Collaborator

@Yougigun Yougigun commented Oct 7, 2024

Because

  • we need to increase stability of using minIO and milvus.
  • we need to provide user friendly error message when file name is too long.

This commit

  • add retry for calling them
  • add custom file name check and return better error message

@linear Linear
Copy link

linear bot commented Oct 7, 2024

INS-6477 [Improvement] Add retry in MinIO and Milvus operations

@Yougigun Yougigun merged commit c5bbf5f into main Oct 7, 2024
10 checks passed
@Yougigun Yougigun deleted the gary/ins-6477-retry-in-minIO-milvus branch October 7, 2024 16:53
@droplet-bot droplet-bot mentioned this pull request Oct 7, 2024
Merged
Yougigun pushed a commit that referenced this pull request Oct 8, 2024
@droplet-bot
chore(main): release 0.17.0-alpha (#110)
00fb8fd 
🤖 I have created a release *beep* *boop*
---


##
[0.17.0-alpha](v0.16.1-alpha...v0.17.0-alpha)
(2024-10-08)


### Features

* **artifact:** add retry in minIO and milvus
([#109](#109))
([c5bbf5f](c5bbf5f))


### Bug Fixes

* **artifact:** add simple rate limiting to use minIO
([#111](#111))
([25043e0](25043e0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm Awaiting requested review from jvallesm jvallesm is a code owner

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yougigun @droplet-bot