fix(artifact): fix retry file process #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yougigun
requested review from
jvallesm,
donch1989 and
pinglin
as code owners
Yougigun
pushed a commit
that referenced
this pull request
Sep 24, 2024
🤖 I have created a release *beep* *boop* --- ## [0.15.0-alpha](v0.14.0-alpha...v0.15.0-alpha) (2024-09-24) ### Features * **artifact:** add response from pipeline when calling fails ([#100](#100)) ([0eef0cc](0eef0cc)) * **artifact:** support csv file type upload and some improvements ([#101](#101)) ([ac2eb86](ac2eb86)) * **artifact:** support xls ([#99](#99)) ([ae30e81](ae30e81)) * **catalog:** add catalog uid in list catalog api ([289fcfa](289fcfa)) ### Bug Fixes * **artifact:** fix retry file process ([#97](#97)) ([97ff707](97ff707)) ### Miscellaneous Chores * release 1.15.0 ([4ac1378](4ac1378)) * release 1.15.0-alpha ([4770a4a](4770a4a)) * release v0.15.0-alpha ([636702d](636702d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
when all processing workers are busy, the dispatch worker continues to send tasks to the queue. These tasks are not held by any workers, so the dispatcher may keep sending the same tasks to the queue.
when chunk text is empty, it still insert into db.
This commit
Add a check at the beginning of each process step to verify the file’s processing state in the database. If the state does not matches the current process state, discard the file process task.
Set buffer of worker queue to zero to prevent out of date file status being queued
Skip the chunk's text if it text is empty