-
Notifications
You must be signed in to change notification settings - Fork 7
Conversation
MEMO: After some investigation, OAuth2, a more secure authentication method, seems incompatible with our use case. Thus, I use the basic token authentication method for the user to access the API. docs: |
b02936c
to
73a130f
Compare
Debug logger will be deleted after the review process is nearly complete. |
4478258
to
0fd2545
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I finished my first review. Thanks for your work.
I want to share with you a general idea about coding.
You can take a look and pick up something you feel make sense.
I always feel writing code should be like writing articles because
- In addition to running code in the computer, other developers will review & refer to code. So, it means the code itself also should be as much readable as possible. And, the structure of code (article) should be clear for human.
- Ideally, we should write the document. But, sometimes we do not have resource. So, I feel code itself should be a good document. It usually brings us good maintainability.
We do sometimes need to code in the language of the computer, but there are always ways to restructure it to make others better to read and understand.
It is my learning from my previous company and senior members.
Just want to share them with you.
235d547
to
bbcdf02
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YCK1130
Left a few comments.
Others LGTM. Please take out debugger if we won't need them.
And, please also make sure this PR can make you create a pipeline that serves marketing purpose.
Because, in v0, there is no insert function, which we cannot fulfil the original story, I think you can bring out other stories.
Looking forward to seeing it!
"properties": { | ||
"project-key-or-id": { | ||
"default": "", | ||
"title": "Project Key or ID", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important.
I forgot if I mentioned here.
But, please make sure how the users get project key or id.
"TASK_GET_SPRINT" | ||
], | ||
"documentationUrl": "https://www.instill.tech/docs/component/application/jira", | ||
"icon": "assets/Jira.svg", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jira.svg
🤖 I have created a release *beep* *boop* --- ## [0.24.0-beta](v0.23.0-beta...v0.24.0-beta) (2024-07-31) ### Features * add audio operator ([#236](#236)) ([fe8abff](fe8abff)) * add handler to auto-fill missing default values ([#210](#210)) ([dcad3f0](dcad3f0)) * add HubSpot component ([#199](#199)) ([b3936a8](b3936a8)) * add Jira component ([#205](#205)) ([51f3ed7](51f3ed7)) * add Ollama component ([#224](#224)) ([810f850](810f850)) * add sql component ([#193](#193)) ([9a373f3](9a373f3)) * add token count for each chunk ([#235](#235)) ([bb69104](bb69104)) * add video operator to fulfil unstructured data process ([#238](#238)) ([a1459d7](a1459d7)) * **document:** add docx doc pptx ppt html to transform to text in markdown format ([#232](#232)) ([2932db9](2932db9)) * **document:** move ConvertToText task from text operator to document operator ([#248](#248)) ([699ca70](699ca70)) * introduce event handler interface ([#253](#253)) ([9599b42](9599b42)) * **restapi:** recategorize the restapi component as a generic component ([#249](#249)) ([fbfc3a3](fbfc3a3)) * **website:** add scrape sitemap function ([#239](#239)) ([8648326](8648326)) ### Bug Fixes * bug of duplicate document ([#256](#256)) ([e028a6e](e028a6e)) * bug of json without setting array for images ([#259](#259)) ([4aeae69](4aeae69)) * change md format to html tag for correct frontend link ([#240](#240)) ([7e16b2b](7e16b2b)) * revert the alias because they are same as package name ([#243](#243)) ([1d9c42d](1d9c42d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Because - We need actions to complete the user story This commit - Provide a draft json schema of each task 8/12 Update I have implemented all functions to connect to the real API and found some tasks are related to some APIs that are not compatible with the current version of Jira. The remaining tasks are: - TASK_CREATE_ISSUE - TASK_UPDATE_ISSUE - TASK_CREATE_SPRINT - TASK_UPDATE_SPRINT -------------- 7/31 Update @chuang8511 Hi, I added three more tasks and moved the schema from v1 to v0 as #205 is merged. There are 5 new tasks now: - TASK_CREATE_ISSUE - TASK_UPDATE_ISSUE - TASK_CREATE_SPRINT - TASK_UPDATE_SPRINT - TASK_RANK_EPIC -------------- 7/25 Note that only the last 3 tasks need to be reviewed, as the others are under review at #205 - TASK_CREATE_ISSUE - TASK_UPDATE_ISSUE - TASK_MOVE_ISSUE_TO_EPIC
Because
This commit
TODO
Next PR
Added by @chuang8511 to visualise Jira's design