Skip to content
This repository has been archived by the owner on Oct 29, 2024. It is now read-only.

refactor: update variable name with initialisms #48

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

donch1989
Copy link
Member

@donch1989 donch1989 commented Jan 12, 2024

Because

  • We want to standardize the naming convention on variable name with initialisms

This commit

  • Enable stylecheck in golangci-lint
  • Update variable name
  • Add golangci-lint Github Action
  • Remove JSON auto-formatter since it will break the readability

Copy link

linear bot commented Jan 12, 2024

Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (792559e) 76.49% compared to head (792fb90) 76.49%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #48   +/-   ##
=======================================
  Coverage   76.49%   76.49%           
=======================================
  Files           1        1           
  Lines         217      217           
=======================================
  Hits          166      166           
  Misses         34       34           
  Partials       17       17           
Flag Coverage Δ
unittests 76.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 marked this pull request as draft January 12, 2024 18:48
@donch1989 donch1989 changed the title refactor: add golang staticcheck refactor: update variable with initialisms name Jan 12, 2024
@donch1989 donch1989 changed the title refactor: update variable with initialisms name refactor: update variable name with initialisms Jan 12, 2024
@donch1989 donch1989 marked this pull request as ready for review January 12, 2024 19:14
@donch1989 donch1989 merged commit 0946e6a into main Jan 12, 2024
12 checks passed
@donch1989 donch1989 deleted the huitang/ins-3385 branch January 12, 2024 19:38
namwoam pushed a commit to namwoam/component that referenced this pull request Jun 24, 2024
Because

- We want to standardize the naming convention on variable name with
initialisms

This commit

- Enable stylecheck in golangci-lint
- Update variable name
- Add golangci-lint Github Action
- Remove JSON auto-formatter since it will break the readability
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants