Skip to content

Commit

Permalink
fix: fix Pages not correctly passing Topbar props (#532)
Browse files Browse the repository at this point in the history
Because

- pages not correctly passing Topbar props 

This commit

- fix Pages not correctly passing Topbar props
  • Loading branch information
EiffelFly authored Sep 7, 2023
1 parent 0458984 commit 72385be
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion src/pages/model-hub/create.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import {
} from "@instill-ai/toolkit";

import { PageTitle, PageHead, Topbar, Sidebar, PageBase } from "@/components";
import { Logo } from "@instill-ai/design-system";

export const getServerSideProps: GetServerSideProps = async () => {
if (env("NEXT_PUBLIC_DISABLE_CREATE_UPDATE_DELETE_RESOURCE")) {
Expand Down Expand Up @@ -89,7 +90,7 @@ const CreateModelPage: FC & {
CreateModelPage.getLayout = (page) => {
return (
<PageBase>
<Topbar />
<Topbar logo={<Logo variant="ColourLogomarkWhiteType" width={180} />} />
<PageBase.Container>
<Sidebar />
<PageBase.Content>{page}</PageBase.Content>
Expand Down
3 changes: 2 additions & 1 deletion src/pages/onboarding.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
Sidebar,
PageBase,
} from "@/components";
import { Logo } from "@instill-ai/design-system";

type GetLayOutProps = {
page: ReactElement;
Expand Down Expand Up @@ -35,7 +36,7 @@ const OnBoardingPage: FC & {
OnBoardingPage.getLayout = (page) => {
return (
<PageBase>
<Topbar />
<Topbar logo={<Logo variant="ColourLogomarkWhiteType" width={180} />} />
<PageBase.Container>
<Sidebar />
<PageBase.Content>{page}</PageBase.Content>
Expand Down

0 comments on commit 72385be

Please sign in to comment.