fix: fix custom task icon #1560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orangecoloured
requested review from
EiffelFly,
pinglin and
xiaofei-du
as code owners
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
1 similar comment
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
EiffelFly
reviewed
Oct 23, 2024
Comment on lines
181
to
186
| <ComplicateIcons.TaskCustom | ||
| className={className ?? "h-4 w-4"} | ||
| pathColor="stroke-semantic-fg-primary" | ||
| /> | ||
| ); |
There was a problem hiding this comment.
@orangecoloured We can use cn and let the consumer decide how to override the default style h-4 w-4
EiffelFly
reviewed
Oct 23, 2024
| @@ -61,7 +61,7 @@ export const ModelsTable = (props: ModelsTableProps) => { | |||
| secondaryLink={null} | |||
| secondaryText={label} | |||
| iconElement={getIcon( | |||
| `w-4 h-4 ${["TASK_CHAT"].includes(row.original.task || "") ? "stroke-semantic-fg-primary [&>*]:!stroke-semantic-fg-primary" : "[&>*]:!fill-semantic-fg-primary"}`, | |||
| `w-4 h-4 ${["TASK_CHAT", "TASK_CUSTOM"].includes(row.original.task || "") ? "stroke-semantic-fg-primary [&>*]:!stroke-semantic-fg-primary" : "[&>*]:!fill-semantic-fg-primary"}`, | |||
There was a problem hiding this comment.
@orangecoloured We can use cn here
cn("w-4 h-4", .......) it will be easier to read compare to template string
orangecoloured
force-pushed
the
alexpetcoglo/ins-6682-bug-task_custom-tag-on-model-overview-displays-wrong
branch
from
bc4e3f3
to
9eb5acc
Compare
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
EiffelFly
reviewed
Oct 23, 2024
Co-authored-by: Po Chun Chiu <[email protected]>
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
📦 Next.js Bundle Analysis for instillai-consoleThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
orangecoloured
deleted the
alexpetcoglo/ins-6682-bug-task_custom-tag-on-model-overview-displays-wrong
branch
Merged
EiffelFly
pushed a commit
that referenced
this pull request
Oct 24, 2024
🤖 I have created a release *beep* *boop* --- <details><summary>0.61.0-beta</summary> ## [0.61.0-beta](v0.60.0-beta...v0.61.0-beta) (2024-10-24) ### Features * support default value for variable ([#1562](#1562)) ([1fdb718](1fdb718)) ### Miscellaneous * retire vdp-sdk/mgmt ([#1557](#1557)) ([f683265](f683265)) </details> <details><summary>@instill-ai/design-system: 0.82.1</summary> ## [0.82.1](https://github.com/instill-ai/console/compare/@instill-ai/design-system-v0.82.0...@instill-ai/design-system-v0.82.1) (2024-10-24) ### Bug Fixes * fix custom task icon ([#1560](#1560)) ([2477f00](2477f00)) </details> <details><summary>@instill-ai/toolkit: 0.109.0</summary> ## [0.109.0](https://github.com/instill-ai/console/compare/@instill-ai/toolkit-v0.108.0...@instill-ai/toolkit-v0.109.0) (2024-10-24) ### Features * show credit owner for runs ([#1561](#1561)) ([93a275a](93a275a)) * support default value for variable ([#1562](#1562)) ([1fdb718](1fdb718)) ### Bug Fixes * fix custom task icon ([#1560](#1560)) ([2477f00](2477f00)) ### Miscellaneous * retire vdp-sdk/mgmt ([#1557](#1557)) ([f683265](f683265)) </details> <details><summary>instill-sdk: 0.10.0</summary> ## [0.10.0](instill-sdk-v0.9.0...instill-sdk-v0.10.0) (2024-10-24) ### Features * show credit owner for runs ([#1561](#1561)) ([93a275a](93a275a)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.