Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metric): model trigger table record api #247

Closed
wants to merge 1 commit into from
Closed

feat(metric): model trigger table record api #247

wants to merge 1 commit into from

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Nov 4, 2024 •
edited
Loading

Because

  • dashboard needs API for model trigger completed/error count

This commit

  • add new metrics API

image

@linear Linear
Copy link

linear bot commented Nov 4, 2024

INS-6757 model trigger table records api

@donch1989 donch1989 requested a review from jvallesm November 4, 2024 07:22
@donch1989
Copy link
Member

Hi @jvallesm
Could you help review this? 🙇

jvallesm
jvallesm reviewed Nov 4, 2024
View reviewed changes
Copy link
Collaborator

@jvallesm jvallesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be implemented as GetModelTriggerCount following GetPipelineTriggerCount

@joremysh joremysh closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvallesm jvallesm jvallesm left review comments

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees
No one assigned
Labels
instill core
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joremysh @donch1989 @jvallesm @droplet-bot