Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(service): remove connector resource state check #250

Conversation

donch1989
Copy link
Member

Because

  • the UX for checking connector resource state when releasing is not friendly

This commit

  • remove connector resource state check

@linear
Copy link

linear bot commented Sep 20, 2023

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7ca469b) 0.00% compared to head (97b6e4b) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #250   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines       1852    1836   -16     
=====================================
+ Misses      1852    1836   -16     
Flag Coverage Δ
unittests 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/service/validator.go 0.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit c1fdb8e into main Sep 20, 2023
13 checks passed
@donch1989 donch1989 deleted the huitang/ins-1993-remove-connector-resource-state-check-in-pipeline-backend branch September 20, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 👋 Done
Development

Successfully merging this pull request may close these issues.

2 participants