Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(service): fix pipeline_release state bug #264

Merged
merged 1 commit into from
Sep 30, 2023

Conversation

donch1989
Copy link
Member

Because

  • the state of pipeline_release was not correctly set

This commit

  • fix pipeline_release state bug

@linear
Copy link

linear bot commented Sep 30, 2023

INS-2223 Fix pipeline release etcd bug

xiaofei.du said in INS-2155:

🐛 Bug:

Displaying errors during release creation, while the process is actually successful.

CleanShot 2023-09-29 at 22.33.15.mp4

@codecov
Copy link

codecov bot commented Sep 30, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (60c41d5) 0.00% compared to head (b6373b3) 0.00%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #264   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files          7       7           
  Lines       2047    2059   +12     
=====================================
- Misses      2047    2059   +12     
Flag Coverage Δ
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/service/openapi.go 0.00% <0.00%> (ø)
pkg/service/service.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@donch1989 donch1989 merged commit d642f8d into main Sep 30, 2023
12 checks passed
@donch1989 donch1989 deleted the huitang/ins-2223-fix-pipeline-release-etcd-bug branch September 30, 2023 03:43
donch1989 pushed a commit that referenced this pull request Sep 30, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.15.1-alpha](v0.15.0-alpha...v0.15.1-alpha)
(2023-09-30)


### Features

* **permission:** support permission setting, sharing public, sharing by
code(link)
([#256](#256))
([a9e42e2](a9e42e2))


### Bug Fixes

* **handler:** fix PATCH pipeline mask bug
([#263](#263))
([60c41d5](60c41d5))
* **proto,handler:** use `int32` in proto pkg to prevent the
`total_size` converted to `string`
([#248](#248))
([7ca469b](7ca469b))
* **service:** delete pipeline_release when pipeline is deleted
([#254](#254))
([066682d](066682d))
* **service:** fix pipeline_release recipe conversion bug
([#251](#251))
([5558d7c](5558d7c))
* **service:** fix pipeline_release state bug
([#264](#264))
([d642f8d](d642f8d))
* **service:** fix the component type is unspecified when
`resource_name` in not set
([#258](#258))
([1410706](1410706))


### Miscellaneous Chores

* **release:** release v0.15.1-alpha
([2c1528e](2c1528e))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Sep 30, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.15.1-alpha](v0.15.0-alpha...v0.15.1-alpha)
(2023-09-30)


### Features

* **permission:** support permission setting, sharing public, sharing by
code(link)
([#256](#256))
([a9e42e2](a9e42e2))


### Bug Fixes

* **handler:** fix PATCH pipeline mask bug
([#263](#263))
([60c41d5](60c41d5))
* **proto,handler:** use `int32` in proto pkg to prevent the
`total_size` converted to `string`
([#248](#248))
([7ca469b](7ca469b))
* **service:** delete pipeline_release when pipeline is deleted
([#254](#254))
([066682d](066682d))
* **service:** fix pipeline_release recipe conversion bug
([#251](#251))
([5558d7c](5558d7c))
* **service:** fix pipeline_release state bug
([#264](#264))
([d642f8d](d642f8d))
* **service:** fix the component type is unspecified when
`resource_name` in not set
([#258](#258))
([1410706](1410706))


### Miscellaneous Chores

* **release:** release v0.15.1-alpha
([0400c57](0400c57))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Sep 30, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.15.1-alpha](v0.15.0-alpha...v0.15.1-alpha)
(2023-09-30)


### Features

* **permission:** support permission setting, sharing public, sharing by
code(link)
([#256](#256))
([a9e42e2](a9e42e2))


### Bug Fixes

* **handler:** fix PATCH pipeline mask bug
([#263](#263))
([60c41d5](60c41d5))
* **proto,handler:** use `int32` in proto pkg to prevent the
`total_size` converted to `string`
([#248](#248))
([7ca469b](7ca469b))
* **service:** delete pipeline_release when pipeline is deleted
([#254](#254))
([066682d](066682d))
* **service:** fix pipeline_release recipe conversion bug
([#251](#251))
([5558d7c](5558d7c))
* **service:** fix pipeline_release state bug
([#264](#264))
([d642f8d](d642f8d))
* **service:** fix the component type is unspecified when
`resource_name` in not set
([#258](#258))
([1410706](1410706))


### Miscellaneous Chores

* **release:** release v0.15.1-alpha
([add651f](add651f))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
donch1989 pushed a commit that referenced this pull request Sep 30, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.15.1-alpha](v0.15.0-alpha...v0.15.1-alpha)
(2023-09-30)


### Features

* **permission:** support permission setting, sharing public, sharing by
code(link)
([#256](#256))
([a9e42e2](a9e42e2))


### Bug Fixes

* **handler:** fix PATCH pipeline mask bug
([#263](#263))
([60c41d5](60c41d5))
* **proto,handler:** use `int32` in proto pkg to prevent the
`total_size` converted to `string`
([#248](#248))
([7ca469b](7ca469b))
* **service:** delete pipeline_release when pipeline is deleted
([#254](#254))
([066682d](066682d))
* **service:** fix pipeline_release recipe conversion bug
([#251](#251))
([5558d7c](5558d7c))
* **service:** fix pipeline_release state bug
([#264](#264))
([d642f8d](d642f8d))
* **service:** fix the component type is unspecified when
`resource_name` in not set
([#258](#258))
([1410706](1410706))


### Miscellaneous Chores

* **release:** release v0.15.1-alpha
([de2fb57](de2fb57))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants