Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metrics): send only new format for pipeline trigger metrics #605

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore(metrics): send only new format for pipeline trigger metrics #605

wants to merge 1 commit into from

Conversation

jvallesm
Copy link
Collaborator

Because

  • The new dashboard design requires breaking changes in the metrics, so until the frontend was implemented both the old and new metrics were sent.

This commit

  • Stops sending the metrics with the old format.

@jvallesm jvallesm self-assigned this Aug 22, 2024
@linear Linear
Copy link

linear bot commented Aug 22, 2024

INS-5379 Credit dashboard endpoints

@jvallesm jvallesm changed the title chore(metrics): Send only new format for pipeline trigger metrics chore(metrics): send only new format for pipeline trigger metrics Aug 22, 2024
@donch1989 donch1989 marked this pull request as ready for review August 22, 2024 09:44
@donch1989 donch1989 marked this pull request as draft August 22, 2024 09:44
@jvallesm jvallesm force-pushed the jvalles/ins-5379-credit-dashboard-endpoints branch from ee8deb6 to 7ae67ee Compare October 4, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du

@chuang8511 chuang8511 Awaiting requested review from chuang8511 chuang8511 will be requested when the pull request is marked ready for review chuang8511 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@jvallesm jvallesm

Labels
instill vdp
Projects
No open projects
🔮 Instill Core
Status: 🚧 Planned
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvallesm @droplet-bot