Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(component): fix contribution guidelines and make command #691

Merged
merged 2 commits into from
Oct 2, 2024
Merged

chore(component): fix contribution guidelines and make command #691

merged 2 commits into from
Oct 2, 2024

Conversation

jvallesm
Copy link
Collaborator

@jvallesm jvallesm commented Oct 2, 2024 •
edited
Loading

Because

  • The component definition in the guideline lacks a type, which makes it not
    show up in the console.
  • Make command referenced in guidelines is different than the one in Makefile.

This commit

  • Renames make command.
  • Fixes definition in guidelines.

@jvallesm jvallesm self-assigned this Oct 2, 2024
@jvallesm jvallesm changed the title jvalles/chore update compogen deps chore(component): fix contribution guidelines and make command Oct 2, 2024
@jvallesm jvallesm force-pushed the jvalles/chore-update-compogen-deps branch from fe7f48f to edb4cfd Compare October 2, 2024 09:32
@jvallesm jvallesm marked this pull request as ready for review October 2, 2024 09:32
@jvallesm jvallesm merged commit bca3bed into main Oct 2, 2024
10 checks passed
@jvallesm jvallesm deleted the jvalles/chore-update-compogen-deps branch October 2, 2024 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeorgeWilliamStrong GeorgeWilliamStrong Awaiting requested review from GeorgeWilliamStrong GeorgeWilliamStrong is a code owner

@donch1989 donch1989 Awaiting requested review from donch1989 donch1989 is a code owner

@pinglin pinglin Awaiting requested review from pinglin

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du

Assignees

@jvallesm jvallesm

Labels
instill component instill vdp
Projects
No open projects
🔮 Instill Core
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvallesm @droplet-bot