-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: bigquery mock server #775
base: main
Are you sure you want to change the base?
test: bigquery mock server #775
Conversation
Hi @PrathameshTugaonkar Now, could you
Thanks for your contribution again! |
Thanks @chuang8511 for reviewing and providing suggestions. Is it good to go now? @chuang8511 Point 3 - Should we take that in another ticket? |
Thanks for your question!
No, the issue in this ticket mainly lacks the test code for bigquery component. So, we will still need point 3 in this ticket! |
Okay, Definitely will work towards it. Thanks @chuang8511 ! |
@chuang8511 Please review. Thanks! |
Hi @PrathameshTugaonkar , Thanks for your contribution. What I mean exactly is - we need to do the test like here. In your code, you only test bigquery http fake server. But, you don't interact the bigquery component with the bigquery http fake server. Recently, I happened to build the similar thing. You can also take a look on this as a reference. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this comment.
assert.NotNil(t, client) | ||
} | ||
|
||
func TestExecute(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to test the interaction between the component and fake bigquery server
Because
This commit