Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(collection): add task split #780

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

chuang8511
Copy link
Member

Because

  • it make pipeline easier to manipulate array

This commit

  • add task split

Copy link

linear bot commented Oct 25, 2024

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 90.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 19.58%. Comparing base (f956ead) to head (292bf32).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/component/generic/collection/v0/main.go 90.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #780      +/-   ##
==========================================
- Coverage   19.70%   19.58%   -0.12%     
==========================================
  Files         321      322       +1     
  Lines       64847    65458     +611     
==========================================
+ Hits        12776    12819      +43     
- Misses      50162    50726     +564     
- Partials     1909     1913       +4     
Flag Coverage Δ
unittests 19.58% <90.00%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@GeorgeWilliamStrong GeorgeWilliamStrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From document perspective, LGTM

@pinglin
Copy link
Member

pinglin commented Oct 25, 2024

@chuang8511 Can we separate all tasks into task_* like what the Image operator has done? I found it's getting harder and harder to trace code in a single file across so many components and tasks. cc'd @donch1989 @jvallesm

@jvallesm
Copy link
Collaborator

@chuang8511 Can we separate all tasks into task_* like what the Image operator has done? I found it's getting harder and harder to trace code in a single file across so many components and tasks. cc'd @donch1989 @jvallesm

@pinglin do you mean in this case or as a convention?

To me it depends on the size of the main.go file. When we start a component and we have 1-2 (simple) tasks, I find it beneficial to have everything in a single file vs having several small files. As the component code grows, it makes sense to me to start dividing the logic into files.

But it isn't a strongly-held opinion, I could do with a convention, too.

@chuang8511 chuang8511 marked this pull request as draft October 28, 2024 09:26
@chuang8511 chuang8511 marked this pull request as ready for review October 28, 2024 11:46
@chuang8511
Copy link
Member Author

chuang8511 commented Oct 28, 2024

@chuang8511 Can we separate all tasks into task_* like what the Image operator has done? I found it's getting harder and harder to trace code in a single file across so many components and tasks. cc'd @donch1989 @jvallesm

Updated.
And, change to ConcurrentExecutor

@donch1989 donch1989 merged commit 1719e48 into main Oct 29, 2024
11 checks passed
@donch1989 donch1989 deleted the chunhao/ins-6641-task-split branch October 29, 2024 02:19
donch1989 pushed a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.45.2-beta](v0.45.1-beta...v0.45.2-beta)
(2024-10-29)


### Features

* **collection:** add task split
([#780](#780))
([1719e48](1719e48))


### Miscellaneous Chores

* release v0.45.2-beta
([777a362](777a362))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
jvallesm pushed a commit that referenced this pull request Oct 29, 2024
Because

- it make pipeline easier to manipulate array

This commit

- add task split
jvallesm pushed a commit that referenced this pull request Oct 29, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.45.2-beta](v0.45.1-beta...v0.45.2-beta)
(2024-10-29)


### Features

* **collection:** add task split
([#780](#780))
([1719e48](1719e48))


### Miscellaneous Chores

* release v0.45.2-beta
([777a362](777a362))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

6 participants